zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove clang:find_bad_constructs suppression from logging (part 1).

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I443c0c77cef30a3f5712f72ce88db80d1fb29874
Reviewed-on: https://webrtc-review.googlesource.com/96642
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24567}
This commit is contained in:
Mirko Bonadei
2018-09-03 09:47:38 +02:00
committed by Commit Bot
parent b267b0e021
commit 55d5ef0048
11 changed files with 94 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/rtp_rtcp/source/rtcp_packet/nack.cc
View File

@ -46,8 +46,9 @@ constexpr size_t Nack::kNackItemLength;
// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
// | PID | BLP |
// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Nack::Nack() {}
Nack::~Nack() {}
Nack::Nack() = default;
Nack::Nack(const Nack& rhs) = default;
Nack::~Nack() = default;
bool Nack::Parse(const CommonHeader& packet) {
RTC_DCHECK_EQ(packet.type(), kPacketType);

1
modules/rtp_rtcp/source/rtcp_packet/nack.h
View File

@ -23,6 +23,7 @@ class Nack : public Rtpfb {
public:
static constexpr uint8_t kFeedbackMessageType = 1;
Nack();
Nack(const Nack&);
~Nack() override;
// Parse assumes header is already parsed and validated.

2
modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc
View File

@ -35,6 +35,8 @@ constexpr size_t ReceiverReport::kMaxNumberOfReportBlocks;
ReceiverReport::ReceiverReport() : sender_ssrc_(0) {}
ReceiverReport::ReceiverReport(const ReceiverReport& rhs) = default;
ReceiverReport::~ReceiverReport() = default;
bool ReceiverReport::Parse(const CommonHeader& packet) {

1
modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
View File

@ -26,6 +26,7 @@ class ReceiverReport : public RtcpPacket {
static constexpr size_t kMaxNumberOfReportBlocks = 0x1f;
ReceiverReport();
ReceiverReport(const ReceiverReport&);
~ReceiverReport() override;
// Parse assumes header is already parsed and validated.

2
modules/rtp_rtcp/source/rtcp_packet/remb.cc
View File

@ -41,6 +41,8 @@ constexpr uint8_t Remb::kFeedbackMessageType;
Remb::Remb() : bitrate_bps_(0) {}
Remb::Remb(const Remb& rhs) = default;
Remb::~Remb() = default;
bool Remb::Parse(const CommonHeader& packet) {

1
modules/rtp_rtcp/source/rtcp_packet/remb.h
View File

@ -26,6 +26,7 @@ class Remb : public Psfb {
static constexpr size_t kMaxNumberOfSsrcs = 0xff;
Remb();
Remb(const Remb&);
~Remb() override;
// Parse assumes header is already parsed and validated.