zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure Lossbased BWE v2 target rate is updated before updating probe controller

Browse Source 
Loss based BWE v2 rate is updated immediately when transport feedback is received.
This ensure that when GoogCcNetworkController::MaybeTriggerOnNetworkChanged is invoked, the loss based estimate is updated.

Bug: webrtc:14392
Change-Id: If404576c5793a29096cea52884862807cde8b615
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275306
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38070}
This commit is contained in:
Per Kjellander
2022-09-13 13:31:07 +02:00
committed by WebRTC LUCI CQ
parent 41263fab8f
commit 565e5b0829
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -547,11 +547,14 @@ NetworkControlUpdate GoogCcNetworkController::OnTransportPacketsFeedback(
// call UpdateDelayBasedEstimate after SetSendBitrate. // call UpdateDelayBasedEstimate after SetSendBitrate.
bandwidth_estimation_->UpdateDelayBasedEstimate(report.feedback_time, bandwidth_estimation_->UpdateDelayBasedEstimate(report.feedback_time,
result.target_bitrate); result.target_bitrate);
// Update the estimate in the ProbeController, in case we want to probe.
MaybeTriggerOnNetworkChanged(&update, report.feedback_time);
} }
bandwidth_estimation_->UpdateLossBasedEstimator(report, bandwidth_estimation_->UpdateLossBasedEstimator(report,
result.delay_detector_state); result.delay_detector_state);
if (result.updated) {
// Update the estimate in the ProbeController, in case we want to probe.
MaybeTriggerOnNetworkChanged(&update, report.feedback_time);
}
recovered_from_overuse = result.recovered_from_overuse; recovered_from_overuse = result.recovered_from_overuse;
if (recovered_from_overuse) { if (recovered_from_overuse) {

1
modules/congestion_controller/goog_cc/send_side_bandwidth_estimation.cc
View File

@ -369,6 +369,7 @@ void SendSideBandwidthEstimation::UpdateLossBasedEstimator(
if (LossBasedBandwidthEstimatorV2Enabled()) { if (LossBasedBandwidthEstimatorV2Enabled()) {
loss_based_bandwidth_estimator_v2_.UpdateBandwidthEstimate( loss_based_bandwidth_estimator_v2_.UpdateBandwidthEstimate(
report.packet_feedbacks, delay_based_limit_, delay_detector_state); report.packet_feedbacks, delay_based_limit_, delay_detector_state);
UpdateEstimate(report.feedback_time);
} }
} }