PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc bit tightened up quite a bit (the one in depot_tools is far more relaxed). Remove a few excluded directories from pylint check and fixed/ suppressed all warnings generated. Add GN format check + formatted all GN files using 'gn format'. Cleanup redundant rules in tools/PRESUBMIT.py TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations. Ran it again with a modification in webrtc/build/webrtc.gni, formatted all the GN files and ran it again. R=henrika@webrtc.org, phoglund@webrtc.org Review URL: https://webrtc-codereview.appspot.com/50069004 Cr-Commit-Position: refs/heads/master@{#9274}
This commit is contained in:
Henrik Kjellander
@ -86,7 +86,9 @@ source_set("audio_decoder_interface") {
|
||||
]
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
deps = [ "../..:webrtc_common" ]
|
||||
deps = [
|
||||
"../..:webrtc_common",
|
||||
]
|
||||
}
|
||||
|
||||
source_set("audio_encoder_interface") {
|
||||
@ -96,7 +98,9 @@ source_set("audio_encoder_interface") {
|
||||
]
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
deps = [ "../..:webrtc_common" ]
|
||||
deps = [
|
||||
"../..:webrtc_common",
|
||||
]
|
||||
}
|
||||
|
||||
config("cng_config") {
|
||||
@ -130,9 +134,7 @@ source_set("cng") {
|
||||
}
|
||||
|
||||
config("red_config") {
|
||||
include_dirs = [
|
||||
"codecs/red",
|
||||
]
|
||||
include_dirs = [ "codecs/red" ]
|
||||
}
|
||||
|
||||
source_set("red") {
|
||||
@ -163,12 +165,12 @@ config("g711_config") {
|
||||
|
||||
source_set("g711") {
|
||||
sources = [
|
||||
"codecs/g711/include/audio_encoder_pcm.h",
|
||||
"codecs/g711/include/g711_interface.h",
|
||||
"codecs/g711/audio_encoder_pcm.cc",
|
||||
"codecs/g711/g711_interface.c",
|
||||
"codecs/g711/g711.c",
|
||||
"codecs/g711/g711.h",
|
||||
"codecs/g711/g711_interface.c",
|
||||
"codecs/g711/include/audio_encoder_pcm.h",
|
||||
"codecs/g711/include/g711_interface.h",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -178,7 +180,9 @@ source_set("g711") {
|
||||
":g711_config",
|
||||
]
|
||||
|
||||
deps = [ ":audio_encoder_interface" ]
|
||||
deps = [
|
||||
":audio_encoder_interface",
|
||||
]
|
||||
}
|
||||
|
||||
config("g722_config") {
|
||||
@ -191,12 +195,12 @@ config("g722_config") {
|
||||
source_set("g722") {
|
||||
sources = [
|
||||
"codecs/g722/audio_encoder_g722.cc",
|
||||
"codecs/g722/include/audio_encoder_g722.h",
|
||||
"codecs/g722/include/g722_interface.h",
|
||||
"codecs/g722/g722_interface.c",
|
||||
"codecs/g722/g722_encode.c",
|
||||
"codecs/g722/g722_decode.c",
|
||||
"codecs/g722/g722_enc_dec.h",
|
||||
"codecs/g722/g722_encode.c",
|
||||
"codecs/g722/g722_interface.c",
|
||||
"codecs/g722/include/audio_encoder_g722.h",
|
||||
"codecs/g722/include/g722_interface.h",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -206,7 +210,9 @@ source_set("g722") {
|
||||
":g722_config",
|
||||
]
|
||||
|
||||
deps = [ ":audio_encoder_interface" ]
|
||||
deps = [
|
||||
":audio_encoder_interface",
|
||||
]
|
||||
}
|
||||
|
||||
config("ilbc_config") {
|
||||
@ -218,28 +224,27 @@ config("ilbc_config") {
|
||||
|
||||
source_set("ilbc") {
|
||||
sources = [
|
||||
"codecs/ilbc/audio_encoder_ilbc.cc",
|
||||
"codecs/ilbc/include/audio_encoder_ilbc.h",
|
||||
"codecs/ilbc/abs_quant.c",
|
||||
"codecs/ilbc/abs_quant.h",
|
||||
"codecs/ilbc/abs_quant_loop.c",
|
||||
"codecs/ilbc/abs_quant_loop.h",
|
||||
"codecs/ilbc/audio_encoder_ilbc.cc",
|
||||
"codecs/ilbc/augmented_cb_corr.c",
|
||||
"codecs/ilbc/augmented_cb_corr.h",
|
||||
"codecs/ilbc/bw_expand.c",
|
||||
"codecs/ilbc/bw_expand.h",
|
||||
"codecs/ilbc/cb_construct.c",
|
||||
"codecs/ilbc/cb_construct.h",
|
||||
"codecs/ilbc/cb_mem_energy.c",
|
||||
"codecs/ilbc/cb_mem_energy.h",
|
||||
"codecs/ilbc/cb_mem_energy_augmentation.c",
|
||||
"codecs/ilbc/cb_mem_energy_augmentation.h",
|
||||
"codecs/ilbc/cb_mem_energy.c",
|
||||
"codecs/ilbc/cb_mem_energy_calc.c",
|
||||
"codecs/ilbc/cb_mem_energy_calc.h",
|
||||
"codecs/ilbc/cb_mem_energy.h",
|
||||
"codecs/ilbc/cb_search.c",
|
||||
"codecs/ilbc/cb_search.h",
|
||||
"codecs/ilbc/cb_search_core.c",
|
||||
"codecs/ilbc/cb_search_core.h",
|
||||
"codecs/ilbc/cb_search.h",
|
||||
"codecs/ilbc/cb_update_best_index.c",
|
||||
"codecs/ilbc/cb_update_best_index.h",
|
||||
"codecs/ilbc/chebyshev.c",
|
||||
@ -263,12 +268,12 @@ source_set("ilbc") {
|
||||
"codecs/ilbc/encode.h",
|
||||
"codecs/ilbc/energy_inverse.c",
|
||||
"codecs/ilbc/energy_inverse.h",
|
||||
"codecs/ilbc/enh_upsample.c",
|
||||
"codecs/ilbc/enh_upsample.h",
|
||||
"codecs/ilbc/enhancer.c",
|
||||
"codecs/ilbc/enhancer.h",
|
||||
"codecs/ilbc/enhancer_interface.c",
|
||||
"codecs/ilbc/enhancer_interface.h",
|
||||
"codecs/ilbc/enh_upsample.c",
|
||||
"codecs/ilbc/enh_upsample.h",
|
||||
"codecs/ilbc/filtered_cb_vecs.c",
|
||||
"codecs/ilbc/filtered_cb_vecs.h",
|
||||
"codecs/ilbc/frame_classify.c",
|
||||
@ -288,6 +293,7 @@ source_set("ilbc") {
|
||||
"codecs/ilbc/hp_output.c",
|
||||
"codecs/ilbc/hp_output.h",
|
||||
"codecs/ilbc/ilbc.c",
|
||||
"codecs/ilbc/include/audio_encoder_ilbc.h",
|
||||
"codecs/ilbc/index_conv_dec.c",
|
||||
"codecs/ilbc/index_conv_dec.h",
|
||||
"codecs/ilbc/index_conv_enc.c",
|
||||
@ -397,8 +403,8 @@ source_set("isac") {
|
||||
"codecs/isac/main/source/codec.h",
|
||||
"codecs/isac/main/source/crc.c",
|
||||
"codecs/isac/main/source/crc.h",
|
||||
"codecs/isac/main/source/decode_bwe.c",
|
||||
"codecs/isac/main/source/decode.c",
|
||||
"codecs/isac/main/source/decode_bwe.c",
|
||||
"codecs/isac/main/source/encode.c",
|
||||
"codecs/isac/main/source/encode_lpc_swb.c",
|
||||
"codecs/isac/main/source/encode_lpc_swb.h",
|
||||
@ -406,10 +412,10 @@ source_set("isac") {
|
||||
"codecs/isac/main/source/entropy_coding.h",
|
||||
"codecs/isac/main/source/fft.c",
|
||||
"codecs/isac/main/source/fft.h",
|
||||
"codecs/isac/main/source/filterbanks.c",
|
||||
"codecs/isac/main/source/filter_functions.c",
|
||||
"codecs/isac/main/source/filterbank_tables.c",
|
||||
"codecs/isac/main/source/filterbank_tables.h",
|
||||
"codecs/isac/main/source/filter_functions.c",
|
||||
"codecs/isac/main/source/filterbanks.c",
|
||||
"codecs/isac/main/source/intialize.c",
|
||||
"codecs/isac/main/source/isac.c",
|
||||
"codecs/isac/main/source/lattice.c",
|
||||
@ -477,17 +483,17 @@ source_set("isacfix") {
|
||||
"codecs/isac/fix/source/bandwidth_estimator.c",
|
||||
"codecs/isac/fix/source/bandwidth_estimator.h",
|
||||
"codecs/isac/fix/source/codec.h",
|
||||
"codecs/isac/fix/source/decode_bwe.c",
|
||||
"codecs/isac/fix/source/decode.c",
|
||||
"codecs/isac/fix/source/decode_bwe.c",
|
||||
"codecs/isac/fix/source/decode_plc.c",
|
||||
"codecs/isac/fix/source/encode.c",
|
||||
"codecs/isac/fix/source/entropy_coding.c",
|
||||
"codecs/isac/fix/source/entropy_coding.h",
|
||||
"codecs/isac/fix/source/fft.c",
|
||||
"codecs/isac/fix/source/fft.h",
|
||||
"codecs/isac/fix/source/filterbanks.c",
|
||||
"codecs/isac/fix/source/filterbank_tables.c",
|
||||
"codecs/isac/fix/source/filterbank_tables.h",
|
||||
"codecs/isac/fix/source/filterbanks.c",
|
||||
"codecs/isac/fix/source/filters.c",
|
||||
"codecs/isac/fix/source/initialize.c",
|
||||
"codecs/isac/fix/source/isacfix.c",
|
||||
@ -544,17 +550,13 @@ source_set("isacfix") {
|
||||
# //build/config/arm.gni instead, to reduce code duplication.
|
||||
# Remove the -mfpu=vfpv3-d16 cflag.
|
||||
configs -= [ "//build/config/compiler:compiler_arm_fpu" ]
|
||||
cflags = [
|
||||
"-mfpu=neon",
|
||||
]
|
||||
cflags = [ "-mfpu=neon" ]
|
||||
|
||||
sources += [
|
||||
"codecs/isac/fix/source/lattice_armv7.S",
|
||||
"codecs/isac/fix/source/pitch_filter_armv6.S",
|
||||
]
|
||||
sources -= [
|
||||
"codecs/isac/fix/source/pitch_filter_c.c",
|
||||
]
|
||||
sources -= [ "codecs/isac/fix/source/pitch_filter_c.c" ]
|
||||
}
|
||||
|
||||
if (current_cpu == "mipsel") {
|
||||
@ -565,22 +567,16 @@ source_set("isacfix") {
|
||||
"codecs/isac/fix/source/pitch_estimator_mips.c",
|
||||
"codecs/isac/fix/source/transform_mips.c",
|
||||
]
|
||||
sources -= [
|
||||
"codecs/isac/fix/source/pitch_estimator_c.c"
|
||||
]
|
||||
sources -= [ "codecs/isac/fix/source/pitch_estimator_c.c" ]
|
||||
if (mips_dsp_rev > 0) {
|
||||
sources += [
|
||||
"codecs/isac/fix/source/filterbanks_mips.c"
|
||||
]
|
||||
sources += [ "codecs/isac/fix/source/filterbanks_mips.c" ]
|
||||
}
|
||||
if (mips_dsp_rev > 1) {
|
||||
sources += [
|
||||
"codecs/isac/fix/source/lpc_masking_model_mips.c",
|
||||
"codecs/isac/fix/source/pitch_filter_mips.c",
|
||||
]
|
||||
sources -= [
|
||||
"codecs/isac/fix/source/pitch_filter_c.c"
|
||||
]
|
||||
sources -= [ "codecs/isac/fix/source/pitch_filter_c.c" ]
|
||||
}
|
||||
}
|
||||
|
||||
@ -606,16 +602,14 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
|
||||
# //build/config/arm.gni instead, to reduce code duplication.
|
||||
# Remove the -mfpu=vfpv3-d16 cflag.
|
||||
configs -= [ "//build/config/compiler:compiler_arm_fpu" ]
|
||||
cflags = [
|
||||
"-mfpu=neon",
|
||||
]
|
||||
cflags = [ "-mfpu=neon" ]
|
||||
}
|
||||
|
||||
if (current_cpu != "arm64" || !is_clang) {
|
||||
# Disable AllpassFilter2FixDec16Neon function due to a clang bug.
|
||||
# Refer more details at:
|
||||
# https://code.google.com/p/webrtc/issues/detail?id=4567
|
||||
sources += [ "codecs/isac/fix/source/filterbanks_neon.c", ]
|
||||
sources += [ "codecs/isac/fix/source/filterbanks_neon.c" ]
|
||||
}
|
||||
|
||||
# Disable LTO in audio_processing_neon target due to compiler bug.
|
||||
@ -629,7 +623,9 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
deps = [ "../../common_audio" ]
|
||||
deps = [
|
||||
"../../common_audio",
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
@ -642,9 +638,9 @@ config("pcm16b_config") {
|
||||
|
||||
source_set("pcm16b") {
|
||||
sources = [
|
||||
"codecs/pcm16b/audio_encoder_pcm16b.cc",
|
||||
"codecs/pcm16b/include/audio_encoder_pcm16b.h",
|
||||
"codecs/pcm16b/include/pcm16b.h",
|
||||
"codecs/pcm16b/audio_encoder_pcm16b.cc",
|
||||
"codecs/pcm16b/pcm16b.c",
|
||||
]
|
||||
|
||||
@ -674,7 +670,9 @@ source_set("webrtc_opus") {
|
||||
"codecs/opus/opus_interface.c",
|
||||
]
|
||||
|
||||
deps = [ ":audio_encoder_interface" ]
|
||||
deps = [
|
||||
":audio_encoder_interface",
|
||||
]
|
||||
|
||||
if (rtc_build_opus) {
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -697,7 +695,6 @@ config("neteq_config") {
|
||||
|
||||
source_set("neteq") {
|
||||
sources = [
|
||||
"neteq/interface/neteq.h",
|
||||
"neteq/accelerate.cc",
|
||||
"neteq/accelerate.h",
|
||||
"neteq/audio_classifier.cc",
|
||||
@ -735,13 +732,12 @@ source_set("neteq") {
|
||||
"neteq/dtmf_tone_generator.h",
|
||||
"neteq/expand.cc",
|
||||
"neteq/expand.h",
|
||||
"neteq/interface/neteq.h",
|
||||
"neteq/merge.cc",
|
||||
"neteq/merge.h",
|
||||
"neteq/neteq.cc",
|
||||
"neteq/neteq_impl.cc",
|
||||
"neteq/neteq_impl.h",
|
||||
"neteq/neteq.cc",
|
||||
"neteq/statistics_calculator.cc",
|
||||
"neteq/statistics_calculator.h",
|
||||
"neteq/normal.cc",
|
||||
"neteq/normal.h",
|
||||
"neteq/packet_buffer.cc",
|
||||
@ -756,12 +752,14 @@ source_set("neteq") {
|
||||
"neteq/random_vector.h",
|
||||
"neteq/rtcp.cc",
|
||||
"neteq/rtcp.h",
|
||||
"neteq/statistics_calculator.cc",
|
||||
"neteq/statistics_calculator.h",
|
||||
"neteq/sync_buffer.cc",
|
||||
"neteq/sync_buffer.h",
|
||||
"neteq/timestamp_scaler.cc",
|
||||
"neteq/timestamp_scaler.h",
|
||||
"neteq/time_stretch.cc",
|
||||
"neteq/time_stretch.h",
|
||||
"neteq/timestamp_scaler.cc",
|
||||
"neteq/timestamp_scaler.h",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
|
||||
@ -18,17 +18,17 @@ config("audio_device_config") {
|
||||
|
||||
source_set("audio_device") {
|
||||
sources = [
|
||||
"include/audio_device.h",
|
||||
"include/audio_device_defines.h",
|
||||
"audio_device_buffer.cc",
|
||||
"audio_device_buffer.h",
|
||||
"audio_device_config.h",
|
||||
"audio_device_generic.cc",
|
||||
"audio_device_generic.h",
|
||||
"audio_device_config.h",
|
||||
"dummy/audio_device_dummy.cc",
|
||||
"dummy/audio_device_dummy.h",
|
||||
"dummy/file_audio_device.cc",
|
||||
"dummy/file_audio_device.h",
|
||||
"include/audio_device.h",
|
||||
"include/audio_device_defines.h",
|
||||
]
|
||||
|
||||
include_dirs = []
|
||||
@ -149,7 +149,7 @@ source_set("audio_device") {
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [
|
||||
"../..:common_inherited_config",
|
||||
":audio_device_config",
|
||||
":audio_device_config",
|
||||
]
|
||||
|
||||
if (is_clang) {
|
||||
@ -166,5 +166,3 @@ source_set("audio_device") {
|
||||
"../utility",
|
||||
]
|
||||
}
|
||||
|
||||
|
||||
|
||||
@ -129,7 +129,9 @@ source_set("audio_processing") {
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
defines = []
|
||||
deps = [ "../..:webrtc_common" ]
|
||||
deps = [
|
||||
"../..:webrtc_common",
|
||||
]
|
||||
|
||||
if (aec_debug_dump) {
|
||||
defines += [ "WEBRTC_AEC_DEBUG_DUMP" ]
|
||||
@ -212,7 +214,9 @@ source_set("audio_processing") {
|
||||
|
||||
if (rtc_enable_protobuf) {
|
||||
proto_library("audioproc_debug_proto") {
|
||||
sources = [ "debug.proto" ]
|
||||
sources = [
|
||||
"debug.proto",
|
||||
]
|
||||
|
||||
proto_out_dir = "webrtc/audio_processing"
|
||||
}
|
||||
@ -246,7 +250,9 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
deps = [ "../../common_audio" ]
|
||||
deps = [
|
||||
"../../common_audio",
|
||||
]
|
||||
|
||||
# Enable compilation for the ARM v7 Neon instruction set. This is needed
|
||||
# since //build/config/arm.gni only enables Neon for iOS, not Android.
|
||||
@ -258,7 +264,7 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
|
||||
|
||||
# "-mfpu=neon" is not requried for arm64 in GCC.
|
||||
if (current_cpu != "arm64") {
|
||||
cflags = [ "-mfpu=neon" ]
|
||||
cflags = [ "-mfpu=neon" ]
|
||||
}
|
||||
|
||||
# Disable LTO in audio_processing_neon target due to compiler bug.
|
||||
|
||||
@ -24,7 +24,7 @@ source_set("bitrate_controller") {
|
||||
if (is_win) {
|
||||
cflags = [
|
||||
# TODO(jschuh): Bug 1348: fix this warning.
|
||||
"/wd4267" # size_t to int truncations
|
||||
"/wd4267", # size_t to int truncations
|
||||
]
|
||||
}
|
||||
|
||||
@ -37,5 +37,7 @@ source_set("bitrate_controller") {
|
||||
configs -= [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
|
||||
deps = [ "../../system_wrappers" ]
|
||||
deps = [
|
||||
"../../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
@ -10,7 +10,7 @@ import("//build/config/ui.gni")
|
||||
import("../../build/webrtc.gni")
|
||||
|
||||
use_desktop_capture_differ_sse2 =
|
||||
(!is_ios && (current_cpu == "x86" || current_cpu == "x64"))
|
||||
!is_ios && (current_cpu == "x86" || current_cpu == "x64")
|
||||
|
||||
source_set("desktop_capture") {
|
||||
sources = [
|
||||
@ -21,17 +21,17 @@ source_set("desktop_capture") {
|
||||
"cropping_window_capturer_win.cc",
|
||||
"desktop_and_cursor_composer.cc",
|
||||
"desktop_and_cursor_composer.h",
|
||||
"desktop_capture_options.cc",
|
||||
"desktop_capture_options.h",
|
||||
"desktop_capture_types.h",
|
||||
"desktop_capturer.h",
|
||||
"desktop_capturer.h",
|
||||
"desktop_frame.cc",
|
||||
"desktop_frame.h",
|
||||
"desktop_frame_win.cc",
|
||||
"desktop_frame_win.h",
|
||||
"desktop_geometry.cc",
|
||||
"desktop_geometry.h",
|
||||
"desktop_capture_options.h",
|
||||
"desktop_capture_options.cc",
|
||||
"desktop_capturer.h",
|
||||
"desktop_region.cc",
|
||||
"desktop_region.h",
|
||||
"differ.cc",
|
||||
@ -40,8 +40,8 @@ source_set("desktop_capture") {
|
||||
"differ_block.h",
|
||||
"mac/desktop_configuration.h",
|
||||
"mac/desktop_configuration.mm",
|
||||
"mac/desktop_configuration_monitor.h",
|
||||
"mac/desktop_configuration_monitor.cc",
|
||||
"mac/desktop_configuration_monitor.h",
|
||||
"mac/full_screen_chrome_window_detector.cc",
|
||||
"mac/full_screen_chrome_window_detector.h",
|
||||
"mac/scoped_pixel_buffer_object.cc",
|
||||
@ -72,12 +72,12 @@ source_set("desktop_capture") {
|
||||
"win/scoped_gdi_object.h",
|
||||
"win/scoped_thread_desktop.cc",
|
||||
"win/scoped_thread_desktop.h",
|
||||
"win/screen_capture_utils.cc",
|
||||
"win/screen_capture_utils.h",
|
||||
"win/screen_capturer_win_gdi.cc",
|
||||
"win/screen_capturer_win_gdi.h",
|
||||
"win/screen_capturer_win_magnifier.cc",
|
||||
"win/screen_capturer_win_magnifier.h",
|
||||
"win/screen_capture_utils.cc",
|
||||
"win/screen_capture_utils.h",
|
||||
"win/window_capture_utils.cc",
|
||||
"win/window_capture_utils.h",
|
||||
"window_capturer.cc",
|
||||
@ -91,14 +91,14 @@ source_set("desktop_capture") {
|
||||
"mouse_cursor_monitor_x11.cc",
|
||||
"screen_capturer_x11.cc",
|
||||
"window_capturer_x11.cc",
|
||||
"x11/shared_x_display.h",
|
||||
"x11/shared_x_display.cc",
|
||||
"x11/shared_x_display.h",
|
||||
"x11/x_error_trap.cc",
|
||||
"x11/x_error_trap.h",
|
||||
"x11/x_server_pixel_buffer.cc",
|
||||
"x11/x_server_pixel_buffer.h",
|
||||
]
|
||||
configs += ["//build/config/linux:x11"]
|
||||
configs += [ "//build/config/linux:x11" ]
|
||||
}
|
||||
|
||||
if (!is_win && !is_mac && !use_x11) {
|
||||
@ -118,7 +118,7 @@ source_set("desktop_capture") {
|
||||
}
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config"]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
if (is_clang) {
|
||||
# Suppress warnings from Chrome's Clang plugins.
|
||||
@ -132,7 +132,7 @@ source_set("desktop_capture") {
|
||||
]
|
||||
|
||||
if (use_desktop_capture_differ_sse2) {
|
||||
deps += [":desktop_capture_differ_sse2"]
|
||||
deps += [ ":desktop_capture_differ_sse2" ]
|
||||
}
|
||||
}
|
||||
|
||||
@ -150,7 +150,7 @@ if (use_desktop_capture_differ_sse2) {
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
if (is_posix && !is_mac) {
|
||||
cflags = ["-msse2"]
|
||||
cflags = [ "-msse2" ]
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ -8,10 +8,10 @@
|
||||
|
||||
source_set("pacing") {
|
||||
sources = [
|
||||
"include/paced_sender.h",
|
||||
"include/packet_router.h",
|
||||
"bitrate_prober.cc",
|
||||
"bitrate_prober.h",
|
||||
"include/paced_sender.h",
|
||||
"include/packet_router.h",
|
||||
"paced_sender.cc",
|
||||
"packet_router.cc",
|
||||
]
|
||||
@ -25,5 +25,7 @@ source_set("pacing") {
|
||||
configs -= [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
|
||||
deps = [ "../../system_wrappers" ]
|
||||
deps = [
|
||||
"../../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
@ -14,7 +14,7 @@ source_set("remote_bitrate_estimator") {
|
||||
"rate_statistics.h",
|
||||
]
|
||||
|
||||
configs += [ "../../:common_inherited_config"]
|
||||
configs += [ "../../:common_inherited_config" ]
|
||||
|
||||
deps = [
|
||||
":rbe_components",
|
||||
@ -43,7 +43,9 @@ source_set("rbe_components") {
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
deps = [ "../..:webrtc_common" ]
|
||||
deps = [
|
||||
"../..:webrtc_common",
|
||||
]
|
||||
|
||||
if (is_clang) {
|
||||
# Suppress warnings from Chrome's Clang plugins.
|
||||
|
||||
@ -10,7 +10,6 @@ import("../../build/webrtc.gni")
|
||||
|
||||
source_set("rtp_rtcp") {
|
||||
sources = [
|
||||
# Common
|
||||
"interface/fec_receiver.h",
|
||||
"interface/receive_statistics.h",
|
||||
"interface/remote_ntp_time_estimator.h",
|
||||
@ -19,18 +18,28 @@ source_set("rtp_rtcp") {
|
||||
"interface/rtp_receiver.h",
|
||||
"interface/rtp_rtcp.h",
|
||||
"interface/rtp_rtcp_defines.h",
|
||||
"mocks/mock_rtp_rtcp.h",
|
||||
"source/bitrate.cc",
|
||||
"source/bitrate.h",
|
||||
"source/byte_io.h",
|
||||
"source/dtmf_queue.cc",
|
||||
"source/dtmf_queue.h",
|
||||
"source/fec_private_tables_bursty.h",
|
||||
"source/fec_private_tables_random.h",
|
||||
"source/fec_receiver_impl.cc",
|
||||
"source/fec_receiver_impl.h",
|
||||
"source/forward_error_correction.cc",
|
||||
"source/forward_error_correction.h",
|
||||
"source/forward_error_correction_internal.cc",
|
||||
"source/forward_error_correction_internal.h",
|
||||
"source/h264_sps_parser.cc",
|
||||
"source/h264_sps_parser.h",
|
||||
"source/mock/mock_rtp_payload_strategy.h",
|
||||
"source/producer_fec.cc",
|
||||
"source/producer_fec.h",
|
||||
"source/receive_statistics_impl.cc",
|
||||
"source/receive_statistics_impl.h",
|
||||
"source/remote_ntp_time_estimator.cc",
|
||||
"source/rtp_header_parser.cc",
|
||||
"source/rtp_rtcp_config.h",
|
||||
"source/rtp_rtcp_impl.cc",
|
||||
"source/rtp_rtcp_impl.h",
|
||||
"source/rtcp_packet.cc",
|
||||
"source/rtcp_packet.h",
|
||||
"source/rtcp_receiver.cc",
|
||||
@ -41,59 +50,46 @@ source_set("rtp_rtcp") {
|
||||
"source/rtcp_sender.h",
|
||||
"source/rtcp_utility.cc",
|
||||
"source/rtcp_utility.h",
|
||||
"source/rtp_format.cc",
|
||||
"source/rtp_format.h",
|
||||
"source/rtp_format_h264.cc",
|
||||
"source/rtp_format_h264.h",
|
||||
"source/rtp_format_video_generic.cc",
|
||||
"source/rtp_format_video_generic.h",
|
||||
"source/rtp_format_vp8.cc",
|
||||
"source/rtp_format_vp8.h",
|
||||
"source/rtp_header_extension.cc",
|
||||
"source/rtp_header_extension.h",
|
||||
"source/rtp_header_parser.cc",
|
||||
"source/rtp_packet_history.cc",
|
||||
"source/rtp_packet_history.h",
|
||||
"source/rtp_payload_registry.cc",
|
||||
"source/rtp_receiver_audio.cc",
|
||||
"source/rtp_receiver_audio.h",
|
||||
"source/rtp_receiver_impl.cc",
|
||||
"source/rtp_receiver_impl.h",
|
||||
"source/rtp_receiver_strategy.cc",
|
||||
"source/rtp_receiver_strategy.h",
|
||||
"source/rtp_receiver_video.cc",
|
||||
"source/rtp_receiver_video.h",
|
||||
"source/rtp_rtcp_config.h",
|
||||
"source/rtp_rtcp_impl.cc",
|
||||
"source/rtp_rtcp_impl.h",
|
||||
"source/rtp_sender.cc",
|
||||
"source/rtp_sender.h",
|
||||
"source/rtp_sender_audio.cc",
|
||||
"source/rtp_sender_audio.h",
|
||||
"source/rtp_sender_video.cc",
|
||||
"source/rtp_sender_video.h",
|
||||
"source/rtp_utility.cc",
|
||||
"source/rtp_utility.h",
|
||||
"source/ssrc_database.cc",
|
||||
"source/ssrc_database.h",
|
||||
"source/tmmbr_help.cc",
|
||||
"source/tmmbr_help.h",
|
||||
# Audio Files
|
||||
"source/dtmf_queue.cc",
|
||||
"source/dtmf_queue.h",
|
||||
"source/rtp_receiver_audio.cc",
|
||||
"source/rtp_receiver_audio.h",
|
||||
"source/rtp_sender_audio.cc",
|
||||
"source/rtp_sender_audio.h",
|
||||
# Video Files
|
||||
"source/fec_private_tables_random.h",
|
||||
"source/fec_private_tables_bursty.h",
|
||||
"source/forward_error_correction.cc",
|
||||
"source/forward_error_correction.h",
|
||||
"source/forward_error_correction_internal.cc",
|
||||
"source/forward_error_correction_internal.h",
|
||||
"source/h264_sps_parser.cc",
|
||||
"source/h264_sps_parser.h",
|
||||
"source/producer_fec.cc",
|
||||
"source/producer_fec.h",
|
||||
"source/rtp_packet_history.cc",
|
||||
"source/rtp_packet_history.h",
|
||||
"source/rtp_payload_registry.cc",
|
||||
"source/rtp_receiver_strategy.cc",
|
||||
"source/rtp_receiver_strategy.h",
|
||||
"source/rtp_receiver_video.cc",
|
||||
"source/rtp_receiver_video.h",
|
||||
"source/rtp_sender_video.cc",
|
||||
"source/rtp_sender_video.h",
|
||||
"source/video_codec_information.h",
|
||||
"source/rtp_format.cc",
|
||||
"source/rtp_format.h",
|
||||
"source/rtp_format_h264.cc",
|
||||
"source/rtp_format_h264.h",
|
||||
"source/rtp_format_vp8.cc",
|
||||
"source/rtp_format_vp8.h",
|
||||
"source/rtp_format_video_generic.cc",
|
||||
"source/rtp_format_video_generic.h",
|
||||
"source/vp8_partition_aggregator.cc",
|
||||
"source/vp8_partition_aggregator.h",
|
||||
# Mocks
|
||||
"mocks/mock_rtp_rtcp.h",
|
||||
"source/mock/mock_rtp_payload_strategy.h",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -116,6 +112,7 @@ source_set("rtp_rtcp") {
|
||||
cflags = [
|
||||
# TODO(jschuh): Bug 1348: fix this warning.
|
||||
"/wd4267", # size_t to int truncations
|
||||
|
||||
# TODO(kjellander): Bug 261: fix this warning.
|
||||
"/wd4373", # virtual function override.
|
||||
]
|
||||
|
||||
@ -128,7 +128,7 @@ if (!build_with_chromium) {
|
||||
|
||||
libs = [ "Strmiids.lib" ]
|
||||
|
||||
deps += [ "//third_party/winsdk_samples"]
|
||||
deps += [ "//third_party/winsdk_samples" ]
|
||||
}
|
||||
if (is_android) {
|
||||
sources = [
|
||||
@ -159,6 +159,7 @@ if (!build_with_chromium) {
|
||||
|
||||
cflags = [
|
||||
"-fobjc-arc", # CLANG_ENABLE_OBJC_ARC = YES.
|
||||
|
||||
# To avoid warnings for deprecated videoMinFrameDuration and
|
||||
# videoMaxFrameDuration properties in iOS 7.0.
|
||||
# See webrtc:3705 for more details.
|
||||
|
||||
@ -44,9 +44,9 @@ source_set("video_coding") {
|
||||
"main/source/nack_fec_tables.h",
|
||||
"main/source/packet.cc",
|
||||
"main/source/packet.h",
|
||||
"main/source/qm_select_data.h",
|
||||
"main/source/qm_select.cc",
|
||||
"main/source/qm_select.h",
|
||||
"main/source/qm_select_data.h",
|
||||
"main/source/receiver.cc",
|
||||
"main/source/receiver.h",
|
||||
"main/source/rtt_filter.cc",
|
||||
@ -110,13 +110,15 @@ source_set("video_coding_utility") {
|
||||
configs -= [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
|
||||
deps = [ "../../system_wrappers" ]
|
||||
deps = [
|
||||
"../../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
source_set("webrtc_i420") {
|
||||
sources = [
|
||||
"codecs/i420/main/source/i420.cc",
|
||||
"codecs/i420/main/interface/i420.h",
|
||||
"codecs/i420/main/source/i420.cc",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -128,7 +130,9 @@ source_set("webrtc_i420") {
|
||||
configs -= [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
|
||||
deps = [ "../../system_wrappers" ]
|
||||
deps = [
|
||||
"../../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
source_set("webrtc_vp8") {
|
||||
@ -174,9 +178,7 @@ source_set("webrtc_vp8") {
|
||||
"../../system_wrappers",
|
||||
]
|
||||
if (rtc_build_libvpx) {
|
||||
deps += [
|
||||
rtc_libvpx_dir,
|
||||
]
|
||||
deps += [ rtc_libvpx_dir ]
|
||||
}
|
||||
}
|
||||
|
||||
@ -190,7 +192,9 @@ source_set("webrtc_vp9") {
|
||||
"codecs/vp9/vp9_impl.h",
|
||||
]
|
||||
} else {
|
||||
sources = [ "codecs/vp9/vp9_dummy_impl.cc" ]
|
||||
sources = [
|
||||
"codecs/vp9/vp9_dummy_impl.cc",
|
||||
]
|
||||
}
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
@ -208,8 +212,6 @@ source_set("webrtc_vp9") {
|
||||
"../../system_wrappers",
|
||||
]
|
||||
if (rtc_build_libvpx) {
|
||||
deps += [
|
||||
rtc_libvpx_dir,
|
||||
]
|
||||
deps += [ rtc_libvpx_dir ]
|
||||
}
|
||||
}
|
||||
|
||||
@ -54,7 +54,9 @@ source_set("video_processing") {
|
||||
|
||||
if (build_video_processing_sse2) {
|
||||
source_set("video_processing_sse2") {
|
||||
sources = [ "main/source/content_analysis_sse2.cc" ]
|
||||
sources = [
|
||||
"main/source/content_analysis_sse2.cc",
|
||||
]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
@ -119,17 +119,17 @@ if (!build_with_chromium) {
|
||||
]
|
||||
|
||||
directxsdk_exists =
|
||||
(exec_script("//build/dir_exists.py",
|
||||
[ rebase_path("//third_party/directxsdk/files",
|
||||
root_build_dir) ],
|
||||
"trim string") == "True")
|
||||
exec_script("//build/dir_exists.py",
|
||||
[ rebase_path("//third_party/directxsdk/files",
|
||||
root_build_dir) ],
|
||||
"trim string") == "True"
|
||||
if (directxsdk_exists) {
|
||||
directxsdk_path = "//third_party/directxsdk/files"
|
||||
} else {
|
||||
directxsdk_path =
|
||||
exec_script("../../build/find_directx_sdk.py", [], "trim string")
|
||||
}
|
||||
include_dirs = [ directxsdk_path + "/Include" ]
|
||||
include_dirs = [ directxsdk_path + "/Include" ]
|
||||
}
|
||||
if (is_android) {
|
||||
sources += [
|
||||
@ -164,7 +164,7 @@ if (!build_with_chromium) {
|
||||
cflags += [ "-fobjc-arc" ] # CLANG_ENABLE_OBJC_ARC = YES.
|
||||
}
|
||||
|
||||
all_dependent_configs = [ ":video_render_internal_impl_config"]
|
||||
all_dependent_configs = [ ":video_render_internal_impl_config" ]
|
||||
|
||||
configs += [ "../..:common_config" ]
|
||||
public_configs = [ "../..:common_inherited_config" ]
|
||||
|
||||
Reference in New Issue
Block a user