zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PRESUBMIT: Improve PyLint check and add GN format check.

Browse Source 
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
This commit is contained in:
Henrik Kjellander
2015-05-25 12:55:39 +02:00
parent 00aac5aacf
commit 57e5fd2e60
40 changed files with 299 additions and 280 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
webrtc/modules/audio_processing/BUILD.gn
View File

@ -129,7 +129,9 @@ source_set("audio_processing") {
public_configs = [ "../..:common_inherited_config" ]
defines = []
deps = [ "../..:webrtc_common" ]
deps = [
"../..:webrtc_common",
]
if (aec_debug_dump) {
defines += [ "WEBRTC_AEC_DEBUG_DUMP" ]
@ -212,7 +214,9 @@ source_set("audio_processing") {
if (rtc_enable_protobuf) {
proto_library("audioproc_debug_proto") {
sources = [ "debug.proto" ]
sources = [
"debug.proto",
]
proto_out_dir = "webrtc/audio_processing"
}
@ -246,7 +250,9 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]
deps = [ "../../common_audio" ]
deps = [
"../../common_audio",
]
# Enable compilation for the ARM v7 Neon instruction set. This is needed
# since //build/config/arm.gni only enables Neon for iOS, not Android.
@ -258,7 +264,7 @@ if (rtc_build_armv7_neon || current_cpu == "arm64") {
# "-mfpu=neon" is not requried for arm64 in GCC.
if (current_cpu != "arm64") {
cflags = [ "-mfpu=neon" ]
cflags = [ "-mfpu=neon" ]
}
# Disable LTO in audio_processing_neon target due to compiler bug.