zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PRESUBMIT: Improve PyLint check and add GN format check.

Browse Source 
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
This commit is contained in:
Henrik Kjellander
2015-05-25 12:55:39 +02:00
parent 00aac5aacf
commit 57e5fd2e60
40 changed files with 299 additions and 280 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
webrtc/modules/video_coding/BUILD.gn
View File

@ -44,9 +44,9 @@ source_set("video_coding") {
"main/source/nack_fec_tables.h",
"main/source/packet.cc",
"main/source/packet.h",
"main/source/qm_select_data.h",
"main/source/qm_select.cc",
"main/source/qm_select.h",
"main/source/qm_select_data.h",
"main/source/receiver.cc",
"main/source/receiver.h",
"main/source/rtt_filter.cc",
@ -110,13 +110,15 @@ source_set("video_coding_utility") {
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
deps = [ "../../system_wrappers" ]
deps = [
"../../system_wrappers",
]
}
source_set("webrtc_i420") {
sources = [
"codecs/i420/main/source/i420.cc",
"codecs/i420/main/interface/i420.h",
"codecs/i420/main/source/i420.cc",
]
configs += [ "../..:common_config" ]
@ -128,7 +130,9 @@ source_set("webrtc_i420") {
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
deps = [ "../../system_wrappers" ]
deps = [
"../../system_wrappers",
]
}
source_set("webrtc_vp8") {
@ -174,9 +178,7 @@ source_set("webrtc_vp8") {
"../../system_wrappers",
]
if (rtc_build_libvpx) {
deps += [
rtc_libvpx_dir,
]
deps += [ rtc_libvpx_dir ]
}
}
@ -190,7 +192,9 @@ source_set("webrtc_vp9") {
"codecs/vp9/vp9_impl.h",
]
} else {
sources = [ "codecs/vp9/vp9_dummy_impl.cc" ]
sources = [
"codecs/vp9/vp9_dummy_impl.cc",
]
}
configs += [ "../..:common_config" ]
@ -208,8 +212,6 @@ source_set("webrtc_vp9") {
"../../system_wrappers",
]
if (rtc_build_libvpx) {
deps += [
rtc_libvpx_dir,
]
deps += [ rtc_libvpx_dir ]
}
}