zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove rtc::Optional::MoveValue

Browse Source 
This function is not present in std::optional
The only use of MoveValue doesn't need move since
copying underneath struct is as correct and as fast as moving

Bug: webrtc:9078
Change-Id: Ic0c87e50ffd8f6c024759b14ceeb8922b5d3a6fd
Reviewed-on: https://webrtc-review.googlesource.com/64986
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22646}
This commit is contained in:
Danil Chapovalov
2018-03-28 11:25:15 +02:00
committed by Commit Bot
parent 467057ec7f
commit 57ff2734df
3 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/optional_unittest.cc
View File

@ -861,7 +861,7 @@ TEST(OptionalTest, TestMoveValue) {
{
Optional<Logger> x(Logger(42));
log->push_back("---");
Logger moved = x.MoveValue();
Logger moved = std::move(x.value());
log->push_back("---");
}
EXPECT_EQ(