zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add AV1 profile-1 video decode support to WebRTC

Browse Source 
The Chrome Remote Desktop team is looking to support AV1 profile-1
w/ I444 for screen sharing however only I420 is currently supported.

This CL adds I444 support for the Dav1dDecoder, which appears to be
the preferred decoder and adds profile-1 to the
InternalDecoderFactory when the Dav1dDecoder is being used.

I've tested this CL using a CRD host w/ I444 enabled and it seems to
work as expected, though I've only tested on a debug build so I plan
to do some perf testing once this is available in a release build.

Bug: chromium:1329660
Change-Id: I2b8b7b7fd530727456ac5c46e694e7dbad6deff2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273986
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Joe Downing <joedow@google.com>
Cr-Commit-Position: refs/heads/main@{#38022}
This commit is contained in:
Joe Downing
2022-09-06 07:22:45 -07:00
committed by WebRTC LUCI CQ
parent 7e7a23fea4
commit 59020bd88b
3 changed files with 112 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
media/engine/internal_decoder_factory_unittest.cc
View File

@ -10,11 +10,13 @@
#include "media/engine/internal_decoder_factory.h"
#include "api/video_codecs/av1_profile.h"
#include "api/video_codecs/sdp_video_format.h"
#include "api/video_codecs/video_decoder.h"
#include "api/video_codecs/vp9_profile.h"
#include "media/base/media_constants.h"
#include "modules/video_coding/codecs/av1/libaom_av1_decoder.h"
#include "system_wrappers/include/field_trial.h"
#include "test/gmock.h"
#include "test/gtest.h"
@ -24,6 +26,8 @@ using ::testing::Contains;
using ::testing::Field;
using ::testing::Not;
using ::webrtc::field_trial::InitFieldTrialsFromString;
#ifdef RTC_ENABLE_VP9
constexpr bool kVp9Enabled = true;
#else
@ -34,10 +38,19 @@ constexpr bool kH264Enabled = true;
#else
constexpr bool kH264Enabled = false;
#endif
#ifdef RTC_DAV1D_IN_INTERNAL_DECODER_FACTORY
constexpr bool kDav1dIsIncluded = true;
#else
constexpr bool kDav1dIsIncluded = false;
#endif
constexpr VideoDecoderFactory::CodecSupport kSupported = {
/*is_supported=*/true, /*is_power_efficient=*/false};
constexpr VideoDecoderFactory::CodecSupport kUnsupported = {
/*is_supported=*/false, /*is_power_efficient=*/false};
constexpr char kDav1dDecoderFieldTrialEnabled[] =
"WebRTC-Dav1dDecoder/Enabled/";
constexpr char kDav1dDecoderFieldTrialDisabled[] =
"WebRTC-Dav1dDecoder/Disabled/";
MATCHER_P(Support, expected, "") {
return arg.is_supported == expected.is_supported &&
@ -76,9 +89,10 @@ TEST(InternalDecoderFactoryTest, H264) {
EXPECT_EQ(static_cast<bool>(decoder), kH264Enabled);
}
TEST(InternalDecoderFactoryTest, Av1) {
TEST(InternalDecoderFactoryTest, Av1Profile0) {
InternalDecoderFactory factory;
if (kIsLibaomAv1DecoderSupported) {
InitFieldTrialsFromString(kDav1dDecoderFieldTrialEnabled);
if (kIsLibaomAv1DecoderSupported || kDav1dIsIncluded) {
EXPECT_THAT(factory.GetSupportedFormats(),
Contains(Field(&SdpVideoFormat::name, cricket::kAv1CodecName)));
EXPECT_TRUE(
@ -90,6 +104,26 @@ TEST(InternalDecoderFactoryTest, Av1) {
}
}
TEST(InternalDecoderFactoryTest, Av1Profile1_Dav1dDecoderTrialEnabled) {
InitFieldTrialsFromString(kDav1dDecoderFieldTrialEnabled);
InternalDecoderFactory factory;
std::unique_ptr<VideoDecoder> decoder = factory.CreateVideoDecoder(
SdpVideoFormat(cricket::kAv1CodecName,
{{kAV1FmtpProfile,
AV1ProfileToString(AV1Profile::kProfile1).data()}}));
EXPECT_EQ(static_cast<bool>(decoder), kDav1dIsIncluded);
}
TEST(InternalDecoderFactoryTest, Av1Profile1_Dav1dDecoderTrialDisabled) {
InitFieldTrialsFromString(kDav1dDecoderFieldTrialDisabled);
InternalDecoderFactory factory;
std::unique_ptr<VideoDecoder> decoder = factory.CreateVideoDecoder(
SdpVideoFormat(cricket::kAv1CodecName,
{{kAV1FmtpProfile,
AV1ProfileToString(AV1Profile::kProfile1).data()}}));
EXPECT_FALSE(static_cast<bool>(decoder));
}
TEST(InternalDecoderFactoryTest, QueryCodecSupportNoReferenceScaling) {
InternalDecoderFactory factory;
EXPECT_THAT(factory.QueryCodecSupport(SdpVideoFormat(cricket::kVp8CodecName),