zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of SSRC and RSID may only refer to one sink each in RtpDemuxer (patchset #15 id:280001 of https://codereview.webrtc.org/2968693002/ )

Browse Source 
Reason for revert:
Some internal tests keep failing after this change. Try to fix it by reverting it. Will reland it if this isn't the root cause.

Original issue's description:
> SSRC and RSID may only refer to one sink each in RtpDemuxer
>
> RTP demuxing should only match RTP packets with one sink.
>
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/2968693002
> Cr-Commit-Position: refs/heads/master@{#19233}
> Committed: 7b7e06fd23

TBR=nisse@webrtc.org,danilchap@webrtc.org,perkj@webrtc.org,stefan@webrtc.org,holmer@google.com,deadbeef@webrtc.org,pthatcher@webrtc.org,steveanton@webrtc.org,eladalon@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2993633002
Cr-Commit-Position: refs/heads/master@{#19239}
This commit is contained in:
zhihuang
2017-08-03 10:09:44 -07:00
committed by Commit Bot
parent 7eaa62bc48
commit 59b603fbed
7 changed files with 105 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/call/rtp_stream_receiver_controller_interface.h
View File

@ -38,7 +38,7 @@ class RtpStreamReceiverControllerInterface {
uint32_t ssrc,
RtpPacketSinkInterface* sink) = 0;
// For registering additional sinks, needed for FlexFEC.
virtual bool AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink) = 0;
virtual void AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink) = 0;
virtual size_t RemoveSink(const RtpPacketSinkInterface* sink) = 0;
};