zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor Cleanup of RTCAudioSource.

Browse Source 
This CL fixes a comment that has the wrong format, and takes over
ownership of an orphaned todo. It also removes some unneeded code
from ObjC classes and moves them to a style more fitting the rest
of the codebase.

BUG=None

Review-Url: https://codereview.webrtc.org/2777453003
Cr-Commit-Position: refs/heads/master@{#17416}
This commit is contained in:
kthelgason
2017-03-28 04:35:58 -07:00
committed by Commit bot
parent 7ac5c32db2
commit 5a4c68e9f3
2 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm
View File

@ -13,10 +13,10 @@
#include "webrtc/base/checks.h" #include "webrtc/base/checks.h"
@implementation RTCAudioSource { @implementation RTCAudioSource {
rtc::scoped_refptr<webrtc::AudioSourceInterface> _nativeAudioSource;
} }
@synthesize volume = _volume; @synthesize volume = _volume;
@synthesize nativeAudioSource = _nativeAudioSource;
- (instancetype)initWithNativeAudioSource: - (instancetype)initWithNativeAudioSource:
(rtc::scoped_refptr<webrtc::AudioSourceInterface>)nativeAudioSource { (rtc::scoped_refptr<webrtc::AudioSourceInterface>)nativeAudioSource {
@ -45,10 +45,4 @@
_nativeAudioSource->SetVolume(volume); _nativeAudioSource->SetVolume(volume);
} }
#pragma mark - Private
- (rtc::scoped_refptr<webrtc::AudioSourceInterface>)nativeAudioSource {
return _nativeAudioSource;
}
@end @end

8
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h
View File

@ -20,11 +20,11 @@ RTC_EXPORT
- (instancetype)init NS_UNAVAILABLE; - (instancetype)init NS_UNAVAILABLE;
// Sets the volume for the RTCMediaSource. |volume] is a gain value in the range // Sets the volume for the RTCMediaSource. |volume| is a gain value in the range
// [0, 10]. // [0, 10].
// Temporary fix to be able to modify volume of remote audio tracks // Temporary fix to be able to modify volume of remote audio tracks.
// TODO: property stays here temporarily until a proper volume-api is avaialble // TODO(kthelgason): Property stays here temporarily until a proper volume-api
// on the surface exposed by webrtc // is available on the surface exposed by webrtc.
@property(nonatomic, assign) double volume; @property(nonatomic, assign) double volume;
@end @end