zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Delete deprecated rtc::Thread default constructor"

Browse Source 
This is a reland of fdd6d3e46e22e1242aa4acd7aa0271a7562fb0ac

Original change's description:
> Delete deprecated rtc::Thread default constructor
>
> Bug: None
> Change-Id: Ic0e2e94b174a49e5d20ebdea90568473e1b71d62
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134640
> Reviewed-by: Tommi <tommi@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27958}

Tbr: tommi@webrtc.org
Bug: None
Change-Id: I9e4b1d06e79670b4efb9c9517d909a0562485e12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137504
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27982}
This commit is contained in:
Niels Möller
2019-04-30 11:45:58 +02:00
committed by Commit Bot
parent 137f6c8952
commit 5a96a0e516
5 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rtc_base/signal_thread_unittest.cc
View File

@ -10,10 +10,11 @@
#include <memory>
#include "absl/memory/memory.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/gunit.h"
#include "rtc_base/null_socket_server.h"
#include "rtc_base/signal_thread.h"
#include "rtc_base/socket_server.h"
#include "rtc_base/thread.h"
#include "test/gtest.h"
@ -129,7 +130,9 @@ class SignalThreadTest : public ::testing::Test, public sigslot::has_slots<> {
class OwnerThread : public Thread, public sigslot::has_slots<> {
public:
explicit OwnerThread(SignalThreadTest* harness)
: harness_(harness), has_run_(false) {}
: Thread(absl::make_unique<NullSocketServer>()),
harness_(harness),
has_run_(false) {}
~OwnerThread() override { Stop(); }