Reland "NetEQ RTP Play: Optionally write output audio file"
This reverts commit c4b391a257ebf85448e58e73a96eb267635b6d6a. Reason for revert: issue fixed Original change's description: > Revert "NetEQ RTP Play: Optionally write output audio file" > > This reverts commit 6330818ec8159ee476481ba4a89f884fb3653f3f. > > Reason for revert: This breaks api/test/neteq_simulator_factory.cc, which unfortunately was not caught by our bots. > > Original change's description: > > NetEQ RTP Play: Optionally write output audio file > > > > This CL makes the output audio file optional to more > > quickly run neteq_rtpplay when no audio output is needed. > > The CL also includes necessary adaptations because of pre-existing > > dependencies (e.g., the output audio file name is used to create > > the plotting script file names). > > > > The command line arguments are retro-compatible - i.e., same behavior > > when specifying the output audio file and the new flag > > --output_files_base_name is not used. > > > > This CL also includes a test script with which the retro-compatibility > > has been verified. > > > > Bug: webrtc:10337 > > Change-Id: Ie3f301b3b2ed0682fb74426d9cf452396f2b112b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126224 > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27067} > > TBR=henrik.lundin@webrtc.org,alessiob@webrtc.org,ivoc@webrtc.org > > Change-Id: I0c63a8ba9566ef567ee398f571f2a511916fa742 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:10337 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127293 > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Commit-Queue: Ivo Creusen <ivoc@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27078} TBR=henrik.lundin@webrtc.org,alessiob@webrtc.org,ivoc@webrtc.org Change-Id: Ia7061f7c2d69db61638ad612e82cd429eb49d539 Bug: webrtc:10337 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127540 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27106}
This commit is contained in:
Alessio Bazzica
committed by
Commit Bot
Commit Bot
parent
123f3453e2
commit
5ad789ceff
183
modules/audio_coding/neteq/tools/neteq_rtpplay_test.sh
Executable file
183
modules/audio_coding/neteq/tools/neteq_rtpplay_test.sh
Executable file
@ -0,0 +1,183 @@
|
||||
#!/bin/bash
|
||||
#
|
||||
# Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
||||
#
|
||||
# Use of this source code is governed by a BSD-style license
|
||||
# that can be found in the LICENSE file in the root of the source
|
||||
# tree. An additional intellectual property rights grant can be found
|
||||
# in the file PATENTS. All contributing project authors may
|
||||
# be found in the AUTHORS file in the root of the source tree.
|
||||
#
|
||||
|
||||
# Aliases.
|
||||
BIN=$1
|
||||
TEST_RTC_EVENT_LOG=$2
|
||||
INPUT_PCM_FILE=$3
|
||||
|
||||
# Check setup.
|
||||
if [ ! -f $BIN ]; then
|
||||
echo "Cannot find neteq_rtpplay binary."
|
||||
exit 99
|
||||
fi
|
||||
if [ ! -f $TEST_RTC_EVENT_LOG ]; then
|
||||
echo "Cannot find RTC event log file."
|
||||
exit 99
|
||||
fi
|
||||
if [ ! -f $INPUT_PCM_FILE ]; then
|
||||
echo "Cannot find PCM file."
|
||||
exit 99
|
||||
fi
|
||||
|
||||
# Defines.
|
||||
|
||||
TMP_DIR=$(mktemp -d /tmp/tmp_XXXXXXXXXX)
|
||||
PASS=0
|
||||
FAIL=1
|
||||
TEST_SUITE_RESULT=$PASS
|
||||
|
||||
file_hash () {
|
||||
md5sum $1 | awk '{ print $1 }'
|
||||
}
|
||||
|
||||
test_passed () {
|
||||
echo PASS
|
||||
}
|
||||
|
||||
test_failed () {
|
||||
echo "FAIL: $1"
|
||||
TEST_SUITE_RESULT=$FAIL
|
||||
}
|
||||
|
||||
test_file_checksums_match () {
|
||||
if [ ! -f $1 ] || [ ! -f $2 ]; then
|
||||
test_failed "Cannot compare hash values: file(s) not found."
|
||||
return
|
||||
fi
|
||||
HASH1=$(file_hash $1)
|
||||
HASH2=$(file_hash $2)
|
||||
if [ "$HASH1" = "$HASH2" ]; then
|
||||
test_passed
|
||||
else
|
||||
test_failed "$1 differs from $2"
|
||||
fi
|
||||
}
|
||||
|
||||
test_file_exists () {
|
||||
if [ -f $1 ]; then
|
||||
test_passed
|
||||
else
|
||||
test_failed "$1 does not exist"
|
||||
fi
|
||||
}
|
||||
|
||||
test_exit_code_0 () {
|
||||
if [ $1 -eq 0 ]; then
|
||||
test_passed
|
||||
else
|
||||
test_failed "$1 did not return 0"
|
||||
fi
|
||||
}
|
||||
|
||||
test_exit_code_not_0 () {
|
||||
if [ $1 -eq 0 ]; then
|
||||
test_failed "$1 returned 0"
|
||||
else
|
||||
test_passed
|
||||
fi
|
||||
}
|
||||
|
||||
# Generate test data.
|
||||
|
||||
# Case 1. Pre-existing way.
|
||||
CASE1_WAV=$TMP_DIR/case1.wav
|
||||
$BIN $TEST_RTC_EVENT_LOG $CASE1_WAV \
|
||||
--replacement_audio_file $INPUT_PCM_FILE \
|
||||
--textlog --pythonplot --matlabplot \
|
||||
> $TMP_DIR/case1.stdout 2> /dev/null
|
||||
CASE1_RETURN_CODE=$?
|
||||
CASE1_TEXTLOG=$TMP_DIR/case1.wav.text_log.txt
|
||||
CASE1_PYPLOT=$TMP_DIR/case1_wav.py
|
||||
CASE1_MATPLOT=$TMP_DIR/case1_wav.m
|
||||
|
||||
# Case 2. No output files.
|
||||
$BIN $TEST_RTC_EVENT_LOG --replacement_audio_file $INPUT_PCM_FILE \
|
||||
> $TMP_DIR/case2.stdout 2> /dev/null
|
||||
CASE2_RETURN_CODE=$?
|
||||
|
||||
# Case 3. No output audio file.
|
||||
|
||||
# Case 3.1 Without --output_files_base_name (won't run).
|
||||
$BIN $TEST_RTC_EVENT_LOG \
|
||||
--replacement_audio_file $INPUT_PCM_FILE \
|
||||
--textlog --pythonplot --matlabplot \
|
||||
&> /dev/null
|
||||
CASE3_1_RETURN_CODE=$?
|
||||
|
||||
# Case 3.2 With --output_files_base_name (runs).
|
||||
$BIN $TEST_RTC_EVENT_LOG \
|
||||
--replacement_audio_file $INPUT_PCM_FILE \
|
||||
--output_files_base_name $TMP_DIR/case3_2 \
|
||||
--textlog --pythonplot --matlabplot \
|
||||
> $TMP_DIR/case3_2.stdout 2> /dev/null
|
||||
CASE3_2_RETURN_CODE=$?
|
||||
CASE3_2_TEXTLOG=$TMP_DIR/case3_2.text_log.txt
|
||||
CASE3_2_PYPLOT=$TMP_DIR/case3_2.py
|
||||
CASE3_2_MATPLOT=$TMP_DIR/case3_2.m
|
||||
|
||||
# Case 4. With output audio file and --output_files_base_name.
|
||||
CASE4_WAV=$TMP_DIR/case4.wav
|
||||
$BIN $TEST_RTC_EVENT_LOG $TMP_DIR/case4.wav \
|
||||
--replacement_audio_file $INPUT_PCM_FILE \
|
||||
--output_files_base_name $TMP_DIR/case4 \
|
||||
--textlog --pythonplot --matlabplot \
|
||||
> $TMP_DIR/case4.stdout 2> /dev/null
|
||||
CASE4_RETURN_CODE=$?
|
||||
CASE4_TEXTLOG=$TMP_DIR/case4.text_log.txt
|
||||
CASE4_PYPLOT=$TMP_DIR/case4.py
|
||||
CASE4_MATPLOT=$TMP_DIR/case4.m
|
||||
|
||||
# Tests.
|
||||
|
||||
echo Check exit codes
|
||||
test_exit_code_0 $CASE1_RETURN_CODE
|
||||
test_exit_code_0 $CASE2_RETURN_CODE
|
||||
test_exit_code_not_0 $CASE3_1_RETURN_CODE
|
||||
test_exit_code_0 $CASE3_2_RETURN_CODE
|
||||
test_exit_code_0 $CASE4_RETURN_CODE
|
||||
|
||||
echo Check that the expected output files exist
|
||||
test_file_exists $CASE1_TEXTLOG
|
||||
test_file_exists $CASE3_2_TEXTLOG
|
||||
test_file_exists $CASE4_TEXTLOG
|
||||
test_file_exists $CASE1_PYPLOT
|
||||
test_file_exists $CASE3_2_PYPLOT
|
||||
test_file_exists $CASE4_PYPLOT
|
||||
test_file_exists $CASE1_MATPLOT
|
||||
test_file_exists $CASE3_2_MATPLOT
|
||||
test_file_exists $CASE4_MATPLOT
|
||||
|
||||
echo Check that the same WAV file is produced
|
||||
test_file_checksums_match $CASE1_WAV $CASE4_WAV
|
||||
|
||||
echo Check that the same text log is produced
|
||||
test_file_checksums_match $CASE1_TEXTLOG $CASE3_2_TEXTLOG
|
||||
test_file_checksums_match $CASE1_TEXTLOG $CASE4_TEXTLOG
|
||||
|
||||
echo Check that the same python plot scripts is produced
|
||||
test_file_checksums_match $CASE1_PYPLOT $CASE3_2_PYPLOT
|
||||
test_file_checksums_match $CASE1_PYPLOT $CASE4_PYPLOT
|
||||
|
||||
echo Check that the same matlab plot scripts is produced
|
||||
test_file_checksums_match $CASE1_MATPLOT $CASE3_2_MATPLOT
|
||||
test_file_checksums_match $CASE1_MATPLOT $CASE4_MATPLOT
|
||||
|
||||
# Clean up
|
||||
rm -fr $TMP_DIR
|
||||
|
||||
if [ $TEST_SUITE_RESULT -eq $PASS ]; then
|
||||
echo All tests passed.
|
||||
exit 0
|
||||
else
|
||||
echo One or more tests failed.
|
||||
exit 1
|
||||
fi
|
||||
Reference in New Issue
Block a user