zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove mutable from rtc::CriticalSection members.

Browse Source 
rtc::CriticalSection is now lockable from const methods and no longer
need to remain mutable.

BUG=
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1613643004

Cr-Commit-Position: refs/heads/master@{#11367}
This commit is contained in:
pbos
2016-01-25 03:52:44 -08:00
committed by Commit bot
parent 7d0d0e0763
commit 5ad935cb56
38 changed files with 49 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_processing/audio_processing_impl.h
View File

@ -239,15 +239,15 @@ class AudioProcessingImpl : public AudioProcessing {
EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);
// Critical section.
mutable rtc::CriticalSection crit_debug_;
rtc::CriticalSection crit_debug_;
// Debug dump state.
ApmDebugDumpState debug_dump_;
#endif
// Critical sections.
mutable rtc::CriticalSection crit_render_ ACQUIRED_BEFORE(crit_capture_);
mutable rtc::CriticalSection crit_capture_;
rtc::CriticalSection crit_render_ ACQUIRED_BEFORE(crit_capture_);
rtc::CriticalSection crit_capture_;
// Structs containing the pointers to the submodules.
rtc::scoped_ptr<ApmPublicSubmodules> public_submodules_;

2
webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
View File

@ -298,7 +298,7 @@ class FrameCounters {
}
private:
mutable rtc::CriticalSection crit_;
rtc::CriticalSection crit_;
int render_count GUARDED_BY(crit_) = 0;
int capture_count GUARDED_BY(crit_) = 0;
};

4
webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
View File

@ -202,7 +202,7 @@ class FrameCounters {
}
private:
mutable rtc::CriticalSection crit_;
rtc::CriticalSection crit_;
int render_count_ GUARDED_BY(crit_) = 0;
int capture_count_ GUARDED_BY(crit_) = 0;
};
@ -221,7 +221,7 @@ class LockedFlag {
}
private:
mutable rtc::CriticalSection crit_;
rtc::CriticalSection crit_;
bool flag_ GUARDED_BY(crit_) = false;
};