zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleaner reading of field trials in GoogCcNetworkController.

Browse Source 
Bug: webrtc:9883
Change-Id: Ib871dfdef6221f2a231f6862edec6ed7db684613
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130515
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27420}
This commit is contained in:
Sebastian Jansson
2019-04-01 17:38:41 +02:00
committed by Commit Bot
parent 7a651c6e58
commit 5b84f67fba
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -69,7 +69,12 @@ int64_t GetBpsOrDefault(const absl::optional<DataRate>& rate,
return fallback_bps;
}
}
bool IsEnabled(const WebRtcKeyValueConfig* config, absl::string_view key) {
return config->Lookup(key).find("Enabled") == 0;
}
bool IsNotDisabled(const WebRtcKeyValueConfig* config, absl::string_view key) {
return config->Lookup(key).find("Disabled") != 0;
}
} // namespace
GoogCcNetworkController::GoogCcNetworkController(RtcEventLog* event_log,
@ -82,14 +87,11 @@ GoogCcNetworkController::GoogCcNetworkController(RtcEventLog* event_log,
safe_reset_on_route_change_("Enabled"),
safe_reset_acknowledged_rate_("ack"),
use_stable_bandwidth_estimate_(
key_value_config_->Lookup("WebRTC-Bwe-StableBandwidthEstimate")
.find("Enabled") == 0),
IsEnabled(key_value_config_, "WebRTC-Bwe-StableBandwidthEstimate")),
fall_back_to_probe_rate_(
key_value_config_->Lookup("WebRTC-Bwe-ProbeRateFallback")
.find("Enabled") == 0),
IsEnabled(key_value_config_, "WebRTC-Bwe-ProbeRateFallback")),
use_min_allocatable_as_lower_bound_(
key_value_config_->Lookup("WebRTC-Bwe-MinAllocAsLowerBound")
.find("Disabled") != 0),
IsNotDisabled(key_value_config_, "WebRTC-Bwe-MinAllocAsLowerBound")),
rate_control_settings_(
RateControlSettings::ParseFromKeyValueConfig(key_value_config_)),
probe_controller_(new ProbeController(key_value_config_, event_log)),