zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Switch to logdog binary provided by IMPLIED_CIPD_BINARIES"

Browse Source 
This reverts commit e05d720f1c8848aef216777d3d02afba0cb2d1e2.

Reason for revert: Cannot find logdog at that path

Original change's description:
> Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
> 
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?q=IMPLIED_CIPD_BINARIES
> to stop having to specify it in
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?q=ANDROID_CIPD_PACKAGES
> 
> Bug: chromium:755660
> Change-Id: I1c69b0bada145ce830c4f62d6e99cc928cd29024
> Reviewed-on: https://webrtc-review.googlesource.com/c/114426
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26015}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

Change-Id: I6ab6a9c4b53e1d2eb90d0294706ca71700f79177
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/c/114428
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26018}
This commit is contained in:
Oleh Prypin
2018-12-14 16:11:48 +00:00
committed by Commit Bot
parent 94f107454e
commit 5bb1afd5c3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools_webrtc/mb/mb.py
View File

@ -839,7 +839,7 @@ class MetaBuildWrapper(object):
elif is_android:
cmdline = ['../../build/android/test_wrapper/logdog_wrapper.py',
'--target', target,
'--logdog-bin-cmd', '../../logdog_butler',
'--logdog-bin-cmd', '../../bin/logdog_butler',
'--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
'--store-tombstones']
else:

4
tools_webrtc/mb/mb_unittest.py
View File

@ -304,7 +304,7 @@ class UnitTest(unittest.TestCase):
self.assertEqual(command, [
'../../build/android/test_wrapper/logdog_wrapper.py',
'--target', 'base_unittests',
'--logdog-bin-cmd', '../../logdog_butler',
'--logdog-bin-cmd', '../../bin/logdog_butler',
'--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
'--store-tombstones',
])
@ -338,7 +338,7 @@ class UnitTest(unittest.TestCase):
self.assertEqual(command, [
'../../build/android/test_wrapper/logdog_wrapper.py',
'--target', 'base_unittests',
'--logdog-bin-cmd', '../../logdog_butler',
'--logdog-bin-cmd', '../../bin/logdog_butler',
'--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
'--store-tombstones',
])