zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ )

Browse Source 
Reason for revert:
Suspect this is breaking the build:
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio

Original issue's description:
> Base webrtc fuzzers on a template.
>
> Removes noisy dependencies on webrtc_fuzzer_main and removal of
> find_bad_constructs, removes 1-6 lines of gn per fuzzer target.
>
> BUG=webrtc:4771
> R=kjellander@webrtc.org
>
> Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f
> Cr-Commit-Position: refs/heads/master@{#11022}

TBR=kjellander@webrtc.org,pbos@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4771

Review URL: https://codereview.webrtc.org/1528043002

Cr-Commit-Position: refs/heads/master@{#11032}
This commit is contained in:
tommi
2015-12-15 10:23:55 -08:00
committed by Commit bot
parent 51254331cc
commit 5e0218c66e
2 changed files with 31 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
webrtc/test/fuzzers/BUILD.gn
View File

@ -7,7 +7,7 @@
# be found in the AUTHORS file in the root of the source tree. # be found in the AUTHORS file in the root of the source tree.
import("//build/config/features.gni") import("//build/config/features.gni")
import("webrtc_fuzzer.gni") import("//testing/test.gni")
static_library("webrtc_fuzzer_main") { static_library("webrtc_fuzzer_main") {
public_configs = [ "../..:common_inherited_config" ] public_configs = [ "../..:common_inherited_config" ]
@ -21,31 +21,51 @@ static_library("webrtc_fuzzer_main") {
] ]
} }
webrtc_fuzzer_test("vp9_depacketizer_fuzzer") { test("vp9_depacketizer_fuzzer") {
sources = [ sources = [
"vp9_depacketizer_fuzzer.cc", "vp9_depacketizer_fuzzer.cc",
] ]
deps = [ deps = [
":webrtc_fuzzer_main",
"../../modules/rtp_rtcp", "../../modules/rtp_rtcp",
] ]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
} }
webrtc_fuzzer_test("vp8_qp_parser_fuzzer") { test("vp8_qp_parser_fuzzer") {
sources = [ sources = [
"vp8_qp_parser_fuzzer.cc", "vp8_qp_parser_fuzzer.cc",
] ]
deps = [ deps = [
":webrtc_fuzzer_main",
"../../modules/video_coding/", "../../modules/video_coding/",
] ]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
} }
webrtc_fuzzer_test("producer_fec_fuzzer") { test("producer_fec_fuzzer") {
sources = [ sources = [
"producer_fec_fuzzer.cc", "producer_fec_fuzzer.cc",
] ]
deps = [ deps = [
":webrtc_fuzzer_main",
"../../modules/rtp_rtcp/", "../../modules/rtp_rtcp/",
] ]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
} }
source_set("audio_decoder_fuzzer") { source_set("audio_decoder_fuzzer") {
@ -53,9 +73,12 @@ source_set("audio_decoder_fuzzer") {
"audio_decoder_fuzzer.cc", "audio_decoder_fuzzer.cc",
"audio_decoder_fuzzer.h", "audio_decoder_fuzzer.h",
] ]
deps = [
":webrtc_fuzzer_main",
]
} }
webrtc_fuzzer_test("audio_decoder_ilbc_fuzzer") { test("audio_decoder_ilbc_fuzzer") {
sources = [ sources = [
"audio_decoder_ilbc_fuzzer.cc", "audio_decoder_ilbc_fuzzer.cc",
] ]
@ -65,7 +88,7 @@ webrtc_fuzzer_test("audio_decoder_ilbc_fuzzer") {
] ]
} }
webrtc_fuzzer_test("audio_decoder_isac_fuzzer") { test("audio_decoder_isac_fuzzer") {
sources = [ sources = [
"audio_decoder_isac_fuzzer.cc", "audio_decoder_isac_fuzzer.cc",
] ]
@ -75,7 +98,7 @@ webrtc_fuzzer_test("audio_decoder_isac_fuzzer") {
] ]
} }
webrtc_fuzzer_test("audio_decoder_isacfix_fuzzer") { test("audio_decoder_isacfix_fuzzer") {
sources = [ sources = [
"audio_decoder_isacfix_fuzzer.cc", "audio_decoder_isacfix_fuzzer.cc",
] ]
@ -85,7 +108,7 @@ webrtc_fuzzer_test("audio_decoder_isacfix_fuzzer") {
] ]
} }
webrtc_fuzzer_test("audio_decoder_opus_fuzzer") { test("audio_decoder_opus_fuzzer") {
sources = [ sources = [
"audio_decoder_opus_fuzzer.cc", "audio_decoder_opus_fuzzer.cc",
] ]

28
webrtc/test/fuzzers/webrtc_fuzzer.gni
View File

@ -1,28 +0,0 @@
# Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import("//testing/test.gni")
template("webrtc_fuzzer_test") {
assert(defined(invoker.sources), "Need sources in $target_name.")
test(target_name) {
forward_variables_from(invoker, [ "sources" ])
deps = [
":webrtc_fuzzer_main",
]
if (defined(invoker.deps)) {
deps += invoker.deps
}
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
}
}