zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Wire up proto-free event log format in encoder and parser."

Browse Source 
This reverts commit 46333dbf6211ea197965c30fdbecbeb62bc81e5b.

Reason for revert: Downstream test broken by changed error message.

Original change's description:
> Wire up proto-free event log format in encoder and parser.
>
> Encode ALR state events as an example. The ALR state unit tests pass with the new format, but the tests are not enabled in this CL since the other event types aren't encoded yet.
>
> Bug: webrtc:11933
> Change-Id: I3ba22778b55f24e2e2bd7d95bb9b17de29ef899f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234520
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35752}

TBR=terelius@webrtc.org,srte@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I9a21ec3c4f876102da146898b840c740f575e03c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11933
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247901
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35753}
This commit is contained in:
Björn Terelius
2022-01-20 16:09:10 +00:00
committed by WebRTC LUCI CQ
parent 46333dbf62
commit 6053903ab9
9 changed files with 25 additions and 448 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
logging/rtc_event_log/rtc_event_log_parser.h
View File

@ -584,7 +584,6 @@ class ParsedRtcEventLog {
private:
ABSL_MUST_USE_RESULT ParseStatus ParseStreamInternal(absl::string_view s);
ABSL_MUST_USE_RESULT ParseStatus ParseStreamInternalV3(absl::string_view s);
ABSL_MUST_USE_RESULT ParseStatus
StoreParsedLegacyEvent(const rtclog::Event& event);