zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix header extension mapping bug in RTC event log analyzer.

Browse Source 
The header extensions for a receive stream should also be used
for the associated RTX stream, but not for the (RTCP) send stream.

Bug: webrtc:10113
Change-Id: Ibeb25a4490d7f628f1b360bf4d6f7edf444ba22a
Reviewed-on: https://webrtc-review.googlesource.com/c/113807
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25955}
This commit is contained in:
Bjorn Terelius
2018-12-10 14:29:46 +01:00
committed by Commit Bot
parent 69b9e136d4
commit 60aaa03ee1
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
logging/rtc_event_log/rtc_event_log_parser_new.cc
View File

@ -1137,10 +1137,7 @@ void ParsedRtcEventLogNew::StoreParsedLegacyEvent(const rtclog::Event& event) {
if (!config.rtp_extensions.empty()) {
incoming_rtp_extensions_maps_[config.remote_ssrc] =
RtpHeaderExtensionMap(config.rtp_extensions);
// TODO(terelius): I don't understand the reason for configuring header
// extensions for the local SSRC. I think it should be removed, but for
// now I want to preserve the previous functionality.
incoming_rtp_extensions_maps_[config.local_ssrc] =
incoming_rtp_extensions_maps_[config.rtx_ssrc] =
RtpHeaderExtensionMap(config.rtp_extensions);
}
incoming_video_ssrcs_.insert(config.remote_ssrc);
@ -1170,8 +1167,6 @@ void ParsedRtcEventLogNew::StoreParsedLegacyEvent(const rtclog::Event& event) {
if (!config.rtp_extensions.empty()) {
incoming_rtp_extensions_maps_[config.remote_ssrc] =
RtpHeaderExtensionMap(config.rtp_extensions);
incoming_rtp_extensions_maps_[config.local_ssrc] =
RtpHeaderExtensionMap(config.rtp_extensions);
}
incoming_audio_ssrcs_.insert(config.remote_ssrc);
break;