zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing conditional visibility.

Browse Source 
Conditional visibility is complex to maintain and it is not well
supported by other build systems.

This CL removes it and falls back on the more relaxed visibility value
("*" in this case).
It is not a problem because the targets that are using conditional
visibility are all marked as "testonly" and this is probably enough to
keep the build graph clean.

Bug: None
Change-Id: I2d2b5ac9a02d08c2863950116db455976ee1459c
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/14902
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20658}
This commit is contained in:
Mirko Bonadei
2017-11-13 10:57:47 +01:00
committed by Commit Bot
parent d328229d38
commit 61a7b141eb
22 changed files with 0 additions and 242 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
modules/audio_coding/BUILD.gn
View File

@ -1224,12 +1224,6 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_modules_tests") {
testonly = true
# Skip restricting visibility on mobile platforms since the tests on those
# gets additional generated targets which would require many lines here to
# cover (which would be confusing to read and hard to maintain).
if (!is_android && !is_ios) {
visibility = [ "..:modules_tests" ]
}
sources = [
"test/ACMTest.h",
"test/APITest.cc",
@ -1292,12 +1286,6 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_perf_tests") {
testonly = true
# Skip restricting visibility on mobile platforms since the tests on those
# gets additional generated targets which would require many lines here to
# cover (which would be confusing to read and hard to maintain).
if (!is_android && !is_ios) {
visibility = [ "../..:webrtc_perf_tests" ]
}
sources = [
"codecs/opus/opus_complexity_unittest.cc",
"neteq/test/neteq_performance_unittest.cc",
@ -2047,12 +2035,6 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_unittests") {
testonly = true
# Skip restricting visibility on mobile platforms since the tests on those
# gets additional generated targets which would require many lines here to
# cover (which would be confusing to read and hard to maintain).
if (!is_android && !is_ios) {
visibility = [ "..:modules_unittests" ]
}
sources = [
"acm2/acm_receiver_unittest.cc",
"acm2/audio_coding_module_unittest.cc",