zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix PeerConnectionInterface::StartRtcEventLog documentation.

Browse Source 
Logging will not stop after 10 minutes but after the max size of the
file is reached.

Bug: None
No-Try: True
Change-Id: I18c064cc60b52d892d5070b3eddf08749b60604c
Reviewed-on: https://webrtc-review.googlesource.com/c/121959
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26625}
This commit is contained in:
Mirko Bonadei
2019-02-08 20:01:00 +01:00
committed by Commit Bot
parent 1a1c52baf9
commit 61b4f7489d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api/peer_connection_interface.h
View File

@ -1057,9 +1057,9 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// Starts RtcEventLog using existing file. Takes ownership of |file| and // Starts RtcEventLog using existing file. Takes ownership of |file| and
// passes it on to Call, which will take the ownership. If the // passes it on to Call, which will take the ownership. If the
// operation fails the file will be closed. The logging will stop // operation fails the file will be closed.
// automatically after 10 minutes have passed, or when the StopRtcEventLog // The logging will stop when |max_size_bytes| is reached or when the
// function is called. // StopRtcEventLog function is called.
// TODO(eladalon): Deprecate and remove this. // TODO(eladalon): Deprecate and remove this.
virtual bool StartRtcEventLog(rtc::PlatformFile file, int64_t max_size_bytes); virtual bool StartRtcEventLog(rtc::PlatformFile file, int64_t max_size_bytes);