zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove top-level const from parameters in function declarations.

Browse Source 
This is a safe cleanup change since top-level const applied to
parameters in function declarations (that are not also
definitions) are ignored by the compiler. Hence, such changes do
not change the type of the declared functions and are simply
no-ops.

Bug: webrtc:13610
Change-Id: Ibafb92c45119a6d8bdb6f9109aa8dad6385163a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249086
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35802}
This commit is contained in:
Ali Tofigh
2022-01-25 13:27:19 +01:00
committed by WebRTC LUCI CQ
parent c98687a2ef
commit 62238097c9
56 changed files with 235 additions and 238 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
examples/unityplugin/simple_peer_connection.h
View File

@ -31,7 +31,7 @@ class SimplePeerConnection : public webrtc::PeerConnectionObserver,
~SimplePeerConnection() {}
bool InitializePeerConnection(const char** turn_urls,
const int no_of_urls,
int no_of_urls,
const char* username,
const char* credential,
bool is_receiver);
@ -56,13 +56,13 @@ class SimplePeerConnection : public webrtc::PeerConnectionObserver,
ICECANDIDATEREADYTOSEND_CALLBACK callback);
bool SetRemoteDescription(const char* type, const char* sdp);
bool AddIceCandidate(const char* sdp,
const int sdp_mlineindex,
int sdp_mlineindex,
const char* sdp_mid);
protected:
// create a peerconneciton and add the turn servers info to the configuration.
bool CreatePeerConnection(const char** turn_urls,
const int no_of_urls,
int no_of_urls,
const char* username,
const char* credential);
void CloseDataChannel();

8
examples/unityplugin/unity_plugin_apis.h
View File

@ -31,7 +31,7 @@ typedef void (*DATAFROMEDATECHANNELREADY_CALLBACK)(const char* msg);
typedef void (*FAILURE_CALLBACK)(const char* msg);
typedef void (*LOCALSDPREADYTOSEND_CALLBACK)(const char* type, const char* sdp);
typedef void (*ICECANDIDATEREADYTOSEND_CALLBACK)(const char* candidate,
const int sdp_mline_index,
int sdp_mline_index,
const char* sdp_mid);
typedef void (*AUDIOBUSREADY_CALLBACK)(const void* audio_data,
int bits_per_sample,
@ -47,7 +47,7 @@ typedef void (*AUDIOBUSREADY_CALLBACK)(const void* audio_data,
extern "C" {
// Create a peerconnection and return a unique peer connection id.
WEBRTC_PLUGIN_API int CreatePeerConnection(const char** turn_urls,
const int no_of_urls,
int no_of_urls,
const char* username,
const char* credential,
bool mandatory_receive_video);
@ -75,9 +75,9 @@ WEBRTC_PLUGIN_API bool SetRemoteDescription(int peer_connection_id,
const char* type,
const char* sdp);
// Add ice candidate.
WEBRTC_PLUGIN_API bool AddIceCandidate(const int peer_connection_id,
WEBRTC_PLUGIN_API bool AddIceCandidate(int peer_connection_id,
const char* candidate,
const int sdp_mlineindex,
int sdp_mlineindex,
const char* sdp_mid);
// Register callback functions.