zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Pass time constant to bwe smoothing filter. (patchset #8 id:140001 of https://codereview.webrtc.org/2518923003/ )

Browse Source 
Reason for revert:
Unfortunately, this change breaks internal projects. Specifically the change to the CongestionController interface means anything implementing it will be forced to change in lock-step.

Original issue's description:
> Pass time constanct to bwe smoothing filter.
>
> BUG=webrtc:6443, webrtc:6303
>
> Committed: https://crrev.com/9abbf5ae4ec7d688a9b4aa03a405f3faadb74b90
> Cr-Commit-Position: refs/heads/master@{#15266}

TBR=minyue@webrtc.org,stefan@webrtc.org,solenberg@webrtc.org,michaelt@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6443, webrtc:6303

Review-Url: https://codereview.webrtc.org/2532993002
Cr-Commit-Position: refs/heads/master@{#15272}
This commit is contained in:
ossu
2016-11-28 08:05:16 -08:00
committed by Commit bot
parent 7703b27c42
commit 6287e82b9b
28 changed files with 128 additions and 248 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/modules/congestion_controller/delay_based_bwe.cc
View File

@ -180,8 +180,7 @@ DelayBasedBwe::DelayBasedBwe(Clock* clock)
trendline_window_size_(kDefaultTrendlineWindowSize),
trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff),
trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
in_trendline_experiment_(TrendlineFilterExperimentIsEnabled()),
probing_interval_estimator_(&rate_control_) {
in_trendline_experiment_(TrendlineFilterExperimentIsEnabled()) {
if (in_trendline_experiment_) {
ReadTrendlineFilterExperimentParameters(&trendline_window_size_,
&trendline_smoothing_coeff_,
@ -331,8 +330,4 @@ void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
// be called from the network thread in the future.
rate_control_.SetMinBitrate(min_bitrate_bps);
}
int64_t DelayBasedBwe::GetProbingIntervalMs() const {
return probing_interval_estimator_.GetIntervalMs();
}
} // namespace webrtc