zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Default the safetyped calculation of packet interarrival times.

Browse Source 
This defaults the calculation landed in cl 196502. The less readable legacy calculation method will be deleted in a future CL.


Bug: none
Change-Id: Ida02a5208e354835b964c69355ad1e9d5bba18aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231956
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35027}
This commit is contained in:
Christoffer Rodbro
2021-09-14 16:24:02 +02:00
committed by WebRTC LUCI CQ
parent 1b200b93d5
commit 62b340545f
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/congestion_controller/goog_cc/delay_based_bwe.cc
View File

@ -95,9 +95,9 @@ DelayBasedBwe::DelayBasedBwe(const WebRtcKeyValueConfig* key_value_config,
prev_bitrate_(DataRate::Zero()), prev_bitrate_(DataRate::Zero()),
has_once_detected_overuse_(false), has_once_detected_overuse_(false),
prev_state_(BandwidthUsage::kBwNormal), prev_state_(BandwidthUsage::kBwNormal),
use_new_inter_arrival_delta_(absl::StartsWith( use_new_inter_arrival_delta_(!absl::StartsWith(
key_value_config->Lookup("WebRTC-Bwe-NewInterArrivalDelta"), key_value_config->Lookup("WebRTC-Bwe-NewInterArrivalDelta"),
"Enabled")), "Disabled")),
alr_limited_backoff_enabled_(absl::StartsWith( alr_limited_backoff_enabled_(absl::StartsWith(
key_value_config->Lookup("WebRTC-Bwe-AlrLimitedBackoff"), key_value_config->Lookup("WebRTC-Bwe-AlrLimitedBackoff"),
"Enabled")) { "Enabled")) {

5
modules/congestion_controller/goog_cc/delay_based_bwe_unittest.cc
View File

@ -31,9 +31,10 @@ constexpr float kTargetUtilizationFraction = 0.95f;
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
, ,
DelayBasedBweTest, DelayBasedBweTest,
::testing::Values("", "WebRTC-Bwe-NewInterArrivalDelta/Enabled/"), ::testing::Values("", "WebRTC-Bwe-NewInterArrivalDelta/Disabled/"),
[](::testing::TestParamInfo<std::string> info) { [](::testing::TestParamInfo<std::string> info) {
return info.param == "" ? "Default" : "NewInterArrival"; return info.param.empty() ? "SafetypedInterArrival"
: "LegacyInterArrival";
}); });
TEST_P(DelayBasedBweTest, ProbeDetection) { TEST_P(DelayBasedBweTest, ProbeDetection) {