zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unit test out of band H264 SPS,PPS within RtpStreamReceiver.

Browse Source 
This CL introduces a dedicated unit test for webrtc::RtpStreamReceiver.
Focus of this CL is testing RtpStreamReciver::OnReceivedPayloadData().
Dependencies with virtual interfaces are (g)mocked, non-virtual
dependencies are instantiated.

This CL is chained to https://codereview.webrtc.org/2638933002/ .

BUG=webrtc:5948

Review-Url: https://codereview.webrtc.org/2641463002
Cr-Commit-Position: refs/heads/master@{#16240}
This commit is contained in:
johan
2017-01-24 04:38:27 -08:00
committed by Commit bot
parent 822d2586fb
commit 62d02c328d
4 changed files with 307 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/modules/video_coding/h264_sprop_parameter_sets.cc
View File

@ -29,6 +29,7 @@ namespace webrtc {
bool H264SpropParameterSets::DecodeSprop(const std::string& sprop) {
size_t separator_pos = sprop.find(',');
LOG(LS_INFO) << "Parsing sprop \"" << sprop << "\"";
if ((separator_pos <= 0) || (separator_pos >= sprop.length() - 1)) {
LOG(LS_WARNING) << "Invalid seperator position " << separator_pos << " *"
<< sprop << "*";