zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using rtc::TaskQueue::Current in RtcpTransceiver

Browse Source 
Bug: webrtc:10191
Change-Id: Ifc080021ebcb203ea72beba8846e940a0c382dd1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126120
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27015}
This commit is contained in:
Danil Chapovalov
2019-03-07 11:15:14 +01:00
committed by Commit Bot
parent dc62ae432d
commit 6318f13295
4 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/rtp_rtcp/source/rtcp_transceiver_impl_unittest.cc
View File

@ -136,7 +136,7 @@ RtcpTransceiverConfig DefaultTestConfig() {
return config;
}
TEST(RtcpTransceiverImplTest, CanDestroyOnTaskQueue) {
TEST(RtcpTransceiverImplTest, NeedToStopPeriodicTaskToDestroyOnTaskQueue) {
FakeRtcpTransport transport;
rtc::TaskQueue queue("rtcp");
RtcpTransceiverConfig config = DefaultTestConfig();
@ -149,6 +149,7 @@ TEST(RtcpTransceiverImplTest, CanDestroyOnTaskQueue) {
rtc::Event done;
queue.PostTask([rtcp_transceiver, &done] {
rtcp_transceiver->StopPeriodicTask();
delete rtcp_transceiver;
done.Set();
});
@ -188,6 +189,7 @@ TEST(RtcpTransceiverImplTest, DelaysSendingFirstCompondPacket) {
// Cleanup.
rtc::Event done;
queue.PostTask([&] {
rtcp_transceiver->StopPeriodicTask();
rtcp_transceiver.reset();
done.Set();
});
@ -221,6 +223,7 @@ TEST(RtcpTransceiverImplTest, PeriodicallySendsPackets) {
// Cleanup.
rtc::Event done;
queue.PostTask([&] {
rtcp_transceiver->StopPeriodicTask();
rtcp_transceiver.reset();
done.Set();
});
@ -266,6 +269,7 @@ TEST(RtcpTransceiverImplTest, SendCompoundPacketDelaysPeriodicSendPackets) {
// Cleanup.
rtc::Event done;
queue.PostTask([&] {
rtcp_transceiver->StopPeriodicTask();
rtcp_transceiver.reset();
done.Set();
});
@ -330,6 +334,7 @@ TEST(RtcpTransceiverImplTest, SendsPeriodicRtcpWhenNetworkStateIsUp) {
// Cleanup.
rtc::Event done;
queue.PostTask([&] {
rtcp_transceiver->StopPeriodicTask();
rtcp_transceiver.reset();
done.Set();
});