zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ReceiveDataParams::timestamp

Browse Source 
This field was only used in RTP Data Channels and isn't needed anymore.

Bug: webrtc:6625
Change-Id: Ieaa7ae03ca3e90eb4ddec4d384f5a76cef1600cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215687
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33791}
This commit is contained in:
Florent Castelli
2021-04-20 15:02:50 +02:00
committed by Commit Bot
parent 49bec37d9b
commit 63b01e19e9
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
media/base/media_channel.h
View File

@ -904,8 +904,6 @@ struct ReceiveDataParams {
DataMessageType type = DMT_TEXT; DataMessageType type = DMT_TEXT;
// A per-stream value incremented per packet in the stream. // A per-stream value incremented per packet in the stream.
int seq_num = 0; int seq_num = 0;
// A per-stream value monotonically increasing with time.
int timestamp = 0;
}; };
struct SendDataParams { struct SendDataParams {

2
media/sctp/usrsctp_transport.cc
View File

@ -1318,8 +1318,6 @@ void UsrsctpTransport::OnDataOrNotificationFromSctp(const void* data,
// Furthermore, it is increased per stream and not on the whole // Furthermore, it is increased per stream and not on the whole
// association. // association.
params.seq_num = rcv.rcv_ssn; params.seq_num = rcv.rcv_ssn;
// There is no timestamp field in the SCTP API
params.timestamp = 0;
// Append the chunk's data to the message buffer // Append the chunk's data to the message buffer
partial_incoming_message_.AppendData(reinterpret_cast<const uint8_t*>(data), partial_incoming_message_.AppendData(reinterpret_cast<const uint8_t*>(data),

4
media/sctp/usrsctp_transport_unittest.cc
View File

@ -576,8 +576,6 @@ TEST_P(SctpTransportTestWithOrdered, SendData) {
RTC_LOG(LS_VERBOSE) << "recv2.received=" << receiver2()->received() RTC_LOG(LS_VERBOSE) << "recv2.received=" << receiver2()->received()
<< ", recv2.last_params.sid=" << ", recv2.last_params.sid="
<< receiver2()->last_params().sid << receiver2()->last_params().sid
<< ", recv2.last_params.timestamp="
<< receiver2()->last_params().timestamp
<< ", recv2.last_params.seq_num=" << ", recv2.last_params.seq_num="
<< receiver2()->last_params().seq_num << receiver2()->last_params().seq_num
<< ", recv2.last_data=" << receiver2()->last_data(); << ", recv2.last_data=" << receiver2()->last_data();
@ -591,8 +589,6 @@ TEST_P(SctpTransportTestWithOrdered, SendData) {
RTC_LOG(LS_VERBOSE) << "recv1.received=" << receiver1()->received() RTC_LOG(LS_VERBOSE) << "recv1.received=" << receiver1()->received()
<< ", recv1.last_params.sid=" << ", recv1.last_params.sid="
<< receiver1()->last_params().sid << receiver1()->last_params().sid
<< ", recv1.last_params.timestamp="
<< receiver1()->last_params().timestamp
<< ", recv1.last_params.seq_num=" << ", recv1.last_params.seq_num="
<< receiver1()->last_params().seq_num << receiver1()->last_params().seq_num
<< ", recv1.last_data=" << receiver1()->last_data(); << ", recv1.last_data=" << receiver1()->last_data();