zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add override declarations to PeerConnectionObserver subclasses, and delete obsolete methods.

Browse Source 
BUG=None

Review-Url: https://codereview.webrtc.org/2660223002
Cr-Commit-Position: refs/heads/master@{#16374}
This commit is contained in:
nisse
2017-01-31 03:34:01 -08:00
committed by Commit bot
parent 1783f169d9
commit 63b14b7d15
4 changed files with 44 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
webrtc/pc/peerconnectioninterface_unittest.cc
View File

@ -547,26 +547,6 @@ class MockPeerConnectionObserver : public PeerConnectionObserver {
EXPECT_EQ(pc_->signaling_state(), new_state);
state_ = new_state;
}
// TODO(bemasc): Remove this once callers transition to OnIceGatheringChange.
virtual void OnStateChange(StateType state_changed) {
if (pc_.get() == NULL)
return;
switch (state_changed) {
case kSignalingState:
// OnSignalingChange and OnStateChange(kSignalingState) should always
// be called approximately simultaneously. To ease testing, we require
// that they always be called in that order. This check verifies
// that OnSignalingChange has just been called.
EXPECT_EQ(pc_->signaling_state(), state_);
break;
case kIceState:
ADD_FAILURE();
break;
default:
ADD_FAILURE();
break;
}
}
MediaStreamInterface* RemoteStream(const std::string& label) {
return remote_streams_->find(label);