zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed static const network units.

Browse Source 
Static const objects can cause what's called a "static initialization
order fiasco". This CL removes the statically initialized network units
in favor of constexpr defined versions available via static functions.

Bug: webrtc:8415
Change-Id: Ib1b316ae007481c52a53b2d1bb0352a630a220e2
Reviewed-on: https://webrtc-review.googlesource.com/65164
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22670}
This commit is contained in:
Sebastian Jansson
2018-03-29 11:00:07 +02:00
committed by Commit Bot
parent 9d2788f745
commit 63b48df334
7 changed files with 77 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/congestion_controller/rtp/send_side_congestion_controller.cc
View File

@ -426,8 +426,8 @@ void SendSideCongestionController::OnNetworkRouteChanged(
msg.at_time = Timestamp::ms(clock_->TimeInMilliseconds());
msg.constraints =
ConvertConstraints(min_bitrate_bps, max_bitrate_bps, clock_);
msg.starting_rate = start_bitrate_bps > 0 ? DataRate::bps(start_bitrate_bps)
: DataRate::kNotInitialized;
msg.starting_rate =
start_bitrate_bps > 0 ? DataRate::bps(start_bitrate_bps) : DataRate();
task_queue_->PostTask([this, msg]() {
RTC_DCHECK_RUN_ON(task_queue_ptr_);
controller_->OnNetworkRouteChange(msg);