zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove WebRTC-ExperimentalScreenshareSettings.

Browse Source 
This field trial is unused.

Bug: webrtc:11503
Change-Id: Id79b0dc64fed3559b9b63ebcf539e5536ddad589
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173339
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31090}
This commit is contained in:
Mirko Bonadei
2020-04-11 16:55:29 +02:00
committed by Commit Bot
parent ec9fc2208e
commit 6415dcad7a
9 changed files with 1 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
rtc_base/experiments/BUILD.gn
View File

@ -182,19 +182,6 @@ rtc_library("keyframe_interval_settings_experiment") {
]
}
rtc_library("experimental_screenshare_settings") {
sources = [
"experimental_screenshare_settings.cc",
"experimental_screenshare_settings.h",
]
deps = [
":field_trial_parser",
"../../api/transport:field_trial_based_config",
"../../api/transport:webrtc_key_value_config",
"//third_party/abseil-cpp/absl/types:optional",
]
}
rtc_library("stable_target_rate_experiment") {
sources = [
"stable_target_rate_experiment.cc",

57
rtc_base/experiments/experimental_screenshare_settings.cc
View File

@ -1,57 +0,0 @@
/*
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "rtc_base/experiments/experimental_screenshare_settings.h"
#include "api/transport/field_trial_based_config.h"
namespace webrtc {
namespace {
constexpr char kFieldTrialName[] = "WebRTC-ExperimentalScreenshareSettings";
} // namespace
ExperimentalScreenshareSettings::ExperimentalScreenshareSettings(
const WebRtcKeyValueConfig* key_value_config)
: max_qp_("max_qp"),
default_tl_in_base_layer_("default_tl_in_base_layer"),
base_layer_max_bitrate_("base_layer_max_bitrate"),
top_layer_max_bitrate("top_layer_max_bitrate") {
ParseFieldTrial({&max_qp_, &default_tl_in_base_layer_,
&base_layer_max_bitrate_, &top_layer_max_bitrate},
key_value_config->Lookup(kFieldTrialName));
}
ExperimentalScreenshareSettings
ExperimentalScreenshareSettings::ParseFromFieldTrials() {
FieldTrialBasedConfig field_trial_config;
return ExperimentalScreenshareSettings(&field_trial_config);
}
absl::optional<int> ExperimentalScreenshareSettings::MaxQp() const {
return max_qp_.GetOptional();
}
absl::optional<bool> ExperimentalScreenshareSettings::DefaultTlInBaseLayer()
const {
return default_tl_in_base_layer_.GetOptional();
}
absl::optional<int> ExperimentalScreenshareSettings::BaseLayerMaxBitrate()
const {
return base_layer_max_bitrate_.GetOptional();
}
absl::optional<int> ExperimentalScreenshareSettings::TopLayerMaxBitrate()
const {
return top_layer_max_bitrate.GetOptional();
}
} // namespace webrtc

40
rtc_base/experiments/experimental_screenshare_settings.h
View File

@ -1,40 +0,0 @@
/*
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef RTC_BASE_EXPERIMENTS_EXPERIMENTAL_SCREENSHARE_SETTINGS_H_
#define RTC_BASE_EXPERIMENTS_EXPERIMENTAL_SCREENSHARE_SETTINGS_H_
#include "absl/types/optional.h"
#include "api/transport/webrtc_key_value_config.h"
#include "rtc_base/experiments/field_trial_parser.h"
namespace webrtc {
class ExperimentalScreenshareSettings {
public:
static ExperimentalScreenshareSettings ParseFromFieldTrials();
explicit ExperimentalScreenshareSettings(
const WebRtcKeyValueConfig* key_value_config);
absl::optional<int> MaxQp() const;
absl::optional<bool> DefaultTlInBaseLayer() const;
absl::optional<int> BaseLayerMaxBitrate() const;
absl::optional<int> TopLayerMaxBitrate() const;
private:
FieldTrialOptional<int> max_qp_;
FieldTrialOptional<bool> default_tl_in_base_layer_;
FieldTrialOptional<int> base_layer_max_bitrate_;
FieldTrialOptional<int> top_layer_max_bitrate;
};
} // namespace webrtc
#endif // RTC_BASE_EXPERIMENTS_EXPERIMENTAL_SCREENSHARE_SETTINGS_H_