Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED

Bug: None
Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30283}
This commit is contained in:
Danil Chapovalov
2020-01-16 14:41:10 +01:00
committed by Commit Bot
parent 4c1086a36a
commit 64f1f3f04e
23 changed files with 130 additions and 384 deletions

View File

@ -58,9 +58,7 @@ rtc_library("video_frame") {
rtc_source_set("recordable_encoded_frame") {
visibility = [ "*" ]
sources = [
"recordable_encoded_frame.h",
]
sources = [ "recordable_encoded_frame.h" ]
deps = [
":encoded_image",
@ -75,9 +73,7 @@ rtc_source_set("recordable_encoded_frame") {
rtc_source_set("video_frame_type") {
visibility = [ "*" ]
sources = [
"video_frame_type.h",
]
sources = [ "video_frame_type.h" ]
}
rtc_library("video_frame_i420") {
@ -146,16 +142,12 @@ rtc_library("encoded_frame") {
"encoded_frame.h",
]
deps = [
"../../modules/video_coding:encoded_frame",
]
deps = [ "../../modules/video_coding:encoded_frame" ]
}
rtc_source_set("video_codec_constants") {
visibility = [ "*" ]
sources = [
"video_codec_constants.h",
]
sources = [ "video_codec_constants.h" ]
deps = []
}
@ -189,9 +181,7 @@ rtc_library("video_bitrate_allocator") {
rtc_source_set("video_bitrate_allocator_factory") {
visibility = [ "*" ]
sources = [
"video_bitrate_allocator_factory.h",
]
sources = [ "video_bitrate_allocator_factory.h" ]
deps = [
":video_bitrate_allocator",
"../../rtc_base:rtc_base_approved",
@ -201,9 +191,7 @@ rtc_source_set("video_bitrate_allocator_factory") {
rtc_source_set("video_stream_decoder") {
visibility = [ "*" ]
sources = [
"video_stream_decoder.h",
]
sources = [ "video_stream_decoder.h" ]
deps = [
":encoded_frame",
@ -288,17 +276,15 @@ rtc_library("builtin_video_bitrate_allocator_factory") {
"../../media:rtc_media_base",
"../../modules/video_coding:video_coding_utility",
"../../modules/video_coding:webrtc_vp9_helpers",
"../../rtc_base/system:fallthrough",
"../video_codecs:video_codecs_api",
"//third_party/abseil-cpp/absl/base:core_headers",
]
}
if (rtc_include_tests) {
rtc_library("video_unittests") {
testonly = true
sources = [
"video_stream_decoder_create_unittest.cc",
]
sources = [ "video_stream_decoder_create_unittest.cc" ]
deps = [
":video_stream_decoder_create",
"../../test:test_support",

View File

@ -12,12 +12,12 @@
#include <memory>
#include "absl/base/macros.h"
#include "api/video/video_bitrate_allocator.h"
#include "api/video_codecs/video_codec.h"
#include "modules/video_coding/codecs/vp9/svc_rate_allocator.h"
#include "modules/video_coding/utility/default_video_bitrate_allocator.h"
#include "modules/video_coding/utility/simulcast_rate_allocator.h"
#include "rtc_base/system/fallthrough.h"
namespace webrtc {
@ -34,7 +34,7 @@ class BuiltinVideoBitrateAllocatorFactory
std::unique_ptr<VideoBitrateAllocator> rate_allocator;
switch (codec.codecType) {
case kVideoCodecVP8:
RTC_FALLTHROUGH();
ABSL_FALLTHROUGH_INTENDED;
case kVideoCodecH264:
rate_allocator.reset(new SimulcastRateAllocator(codec));
break;

View File

@ -58,12 +58,8 @@ rtc_library("video_codecs_api") {
rtc_source_set("bitstream_parser_api") {
visibility = [ "*" ]
sources = [
"bitstream_parser.h",
]
deps = [
"..:array_view",
]
sources = [ "bitstream_parser.h" ]
deps = [ "..:array_view" ]
}
rtc_library("builtin_video_decoder_factory") {
@ -143,13 +139,13 @@ rtc_library("rtc_software_fallback_wrappers") {
"../../modules/video_coding:video_codec_interface",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/system:fallthrough",
"../../rtc_base/system:rtc_export",
"../../system_wrappers:field_trial",
"../video:encoded_image",
"../video:video_bitrate_allocation",
"../video:video_frame",
"../video:video_rtp_headers",
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/types:optional",
]
}

View File

@ -16,12 +16,12 @@
#include <string>
#include <utility>
#include "absl/base/macros.h"
#include "api/video/encoded_image.h"
#include "api/video_codecs/video_codec.h"
#include "modules/video_coding/include/video_error_codes.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/system/fallthrough.h"
#include "rtc_base/trace_event.h"
#include "system_wrappers/include/field_trial.h"
@ -166,7 +166,7 @@ int32_t VideoDecoderSoftwareFallbackWrapper::Decode(
}
// Fallback decoder initialized, fall-through.
RTC_FALLTHROUGH();
ABSL_FALLTHROUGH_INTENDED;
}
case DecoderType::kFallback:
return fallback_decoder_->Decode(input_image, missing_frames,