Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED

Bug: None
Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30283}
This commit is contained in:
Danil Chapovalov
2020-01-16 14:41:10 +01:00
committed by Commit Bot
parent 4c1086a36a
commit 64f1f3f04e
23 changed files with 130 additions and 384 deletions

View File

@ -16,12 +16,8 @@ visibility = [ ":*" ]
rtc_source_set("audio_coding_module_typedefs") {
visibility += [ "*" ]
sources = [
"include/audio_coding_module_typedefs.h",
]
deps = [
"../../rtc_base:deprecation",
]
sources = [ "include/audio_coding_module_typedefs.h" ]
deps = [ "../../rtc_base:deprecation" ]
}
rtc_library("audio_coding") {
@ -144,9 +140,7 @@ rtc_library("g711") {
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
public_deps = [
":g711_c",
]
public_deps = [ ":g711_c" ] # no-presubmit-check TODO(webrtc:8603)
}
rtc_library("g711_c") {
@ -155,9 +149,7 @@ rtc_library("g711_c") {
"codecs/g711/g711_interface.c",
"codecs/g711/g711_interface.h",
]
deps = [
"../third_party/g711:g711_3p",
]
deps = [ "../third_party/g711:g711_3p" ]
}
rtc_library("g722") {
@ -178,9 +170,7 @@ rtc_library("g722") {
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
public_deps = [
":g722_c",
]
public_deps = [ ":g722_c" ] # no-presubmit-check TODO(webrtc:8603)
}
rtc_library("g722_c") {
@ -189,9 +179,7 @@ rtc_library("g722_c") {
"codecs/g722/g722_interface.c",
"codecs/g722/g722_interface.h",
]
deps = [
"../third_party/g722:g722_3p",
]
deps = [ "../third_party/g722:g722_3p" ]
}
rtc_library("ilbc") {
@ -213,9 +201,7 @@ rtc_library("ilbc") {
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
public_deps = [
":ilbc_c",
]
public_deps = [ ":ilbc_c" ] # no-presubmit-check TODO(webrtc:8603)
}
rtc_library("ilbc_c") {
@ -406,15 +392,11 @@ rtc_library("isac") {
":isac_common",
"../../api/audio_codecs:audio_codecs_api",
]
public_deps = [
":isac_c",
]
public_deps = [ ":isac_c" ] # no-presubmit-check TODO(webrtc:8603)
}
rtc_source_set("isac_bwinfo") {
sources = [
"codecs/isac/bandwidth_info.h",
]
sources = [ "codecs/isac/bandwidth_info.h" ]
deps = []
}
@ -517,9 +499,7 @@ rtc_library("isac_fix") {
"../../common_audio",
"../../system_wrappers",
]
public_deps = [
":isac_fix_c",
]
public_deps = [ ":isac_fix_c" ] # no-presubmit-check TODO(webrtc:8603)
if (rtc_build_with_neon) {
deps += [ ":isac_neon" ]
@ -618,9 +598,7 @@ rtc_library("isac_fix_c") {
"../third_party/fft",
]
public_deps = [
":isac_fix_common",
]
public_deps = [ ":isac_fix_common" ] # no-presubmit-check TODO(webrtc:8603)
if (rtc_build_with_neon) {
deps += [ ":isac_neon" ]
@ -713,9 +691,7 @@ rtc_library("pcm16b") {
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
public_deps = [
":pcm16b_c",
]
public_deps = [ ":pcm16b_c" ] # no-presubmit-check TODO(webrtc:8603)
}
rtc_library("pcm16b_c") {
@ -768,9 +744,7 @@ rtc_library("webrtc_opus") {
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
public_deps = [ # no-presubmit-check TODO(webrtc:8603)
":webrtc_opus_wrapper",
]
public_deps = [ ":webrtc_opus_wrapper" ] # no-presubmit-check TODO(webrtc:8603)
defines = audio_codec_defines
@ -806,9 +780,7 @@ rtc_library("webrtc_multiopus") {
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
public_deps = [ # no-presubmit-check TODO(webrtc:8603)
":webrtc_opus_wrapper",
]
public_deps = [ ":webrtc_opus_wrapper" ] # no-presubmit-check TODO(webrtc:8603)
defines = audio_codec_defines
@ -830,9 +802,7 @@ rtc_library("webrtc_opus_wrapper") {
defines = audio_coding_defines
if (rtc_build_opus) {
public_deps = [
rtc_opus_dir,
]
public_deps = [ rtc_opus_dir ] # no-presubmit-check TODO(webrtc:8603)
} else if (build_with_mozilla) {
include_dirs = [ getenv("DIST") + "/include/opus" ]
}
@ -848,17 +818,13 @@ rtc_library("webrtc_opus_wrapper") {
if (rtc_enable_protobuf) {
proto_library("ana_debug_dump_proto") {
visibility += webrtc_default_visibility
sources = [
"audio_network_adaptor/debug_dump.proto",
]
sources = [ "audio_network_adaptor/debug_dump.proto" ]
link_deps = [ ":ana_config_proto" ]
proto_out_dir = "modules/audio_coding/audio_network_adaptor"
}
proto_library("ana_config_proto") {
visibility += [ "*" ]
sources = [
"audio_network_adaptor/config.proto",
]
sources = [ "audio_network_adaptor/config.proto" ]
proto_out_dir = "modules/audio_coding/audio_network_adaptor"
}
}
@ -869,9 +835,7 @@ rtc_library("audio_network_adaptor_config") {
"audio_network_adaptor/audio_network_adaptor_config.cc",
"audio_network_adaptor/include/audio_network_adaptor_config.h",
]
deps = [
"//third_party/abseil-cpp/absl/types:optional",
]
deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
rtc_library("audio_network_adaptor") {
@ -901,9 +865,7 @@ rtc_library("audio_network_adaptor") {
"audio_network_adaptor/util/threshold_curve.h",
]
public_deps = [
":audio_network_adaptor_config",
]
public_deps = [ ":audio_network_adaptor_config" ] # no-presubmit-check TODO(webrtc:8603)
deps = [
"../../api/audio_codecs:audio_codecs_api",
@ -1016,7 +978,6 @@ rtc_library("neteq") {
"../../rtc_base:safe_minmax",
"../../rtc_base:sanitizer",
"../../rtc_base/experiments:field_trial_parser",
"../../rtc_base/system:fallthrough",
"../../system_wrappers",
"../../system_wrappers:field_trial",
"../../system_wrappers:metrics",
@ -1199,9 +1160,7 @@ if (rtc_enable_protobuf) {
"../rtp_rtcp:rtp_rtcp_format",
"//third_party/abseil-cpp/absl/types:optional",
]
public_deps = [
"../../logging:rtc_event_log_proto",
]
public_deps = [ "../../logging:rtc_event_log_proto" ] # no-presubmit-check TODO(webrtc:8603)
}
# Only used for test purpose. Since we want to use it from chromium
@ -1209,9 +1168,7 @@ if (rtc_enable_protobuf) {
# under rtc_include_tests.
proto_library("neteq_unittest_proto") {
testonly = true
sources = [
"neteq/neteq_unittest.proto",
]
sources = [ "neteq/neteq_unittest.proto" ]
proto_out_dir = "modules/audio_coding/neteq"
}
}
@ -1480,17 +1437,13 @@ if (rtc_include_tests) {
bundle_data("audio_decoder_unittests_bundle_data") {
testonly = true
sources = audio_decoder_unittests_resources
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
}
}
rtc_test("audio_decoder_unittests") {
testonly = true
sources = [
"neteq/audio_decoder_unittest.cc",
]
sources = [ "neteq/audio_decoder_unittest.cc" ]
defines = neteq_defines
@ -1564,9 +1517,7 @@ if (rtc_include_tests) {
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
sources = [
"neteq/tools/neteq_rtpplay.cc",
]
sources = [ "neteq/tools/neteq_rtpplay.cc" ]
}
}
@ -1580,18 +1531,14 @@ if (rtc_include_tests) {
bundle_data("audio_codec_speed_tests_data") {
testonly = true
sources = audio_codec_speed_tests_resources
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
}
}
rtc_test("audio_codec_speed_tests") {
testonly = true
defines = []
deps = [
"../../test:fileutils",
]
deps = [ "../../test:fileutils" ]
sources = [
"codecs/isac/fix/test/isac_speed_test.cc",
"codecs/opus/opus_speed_test.cc",
@ -1688,9 +1635,7 @@ if (rtc_include_tests) {
"../../rtc_base:safe_conversions",
]
sources = [
"neteq/tools/rtp_encode.cc",
]
sources = [ "neteq/tools/rtp_encode.cc" ]
defines = audio_coding_defines
}
@ -1704,9 +1649,7 @@ if (rtc_include_tests) {
"../../rtc_base:rtc_base_approved",
]
sources = [
"neteq/tools/rtp_jitter.cc",
]
sources = [ "neteq/tools/rtp_jitter.cc" ]
defines = audio_coding_defines
}
@ -1714,9 +1657,7 @@ if (rtc_include_tests) {
rtc_executable("rtpcat") {
testonly = true
sources = [
"neteq/tools/rtpcat.cc",
]
sources = [ "neteq/tools/rtpcat.cc" ]
deps = [
"../../rtc_base:checks",
@ -1729,9 +1670,7 @@ if (rtc_include_tests) {
rtc_executable("rtp_analyze") {
testonly = true
sources = [
"neteq/tools/rtp_analyze.cc",
]
sources = [ "neteq/tools/rtp_analyze.cc" ]
deps = [
":neteq",
@ -1746,9 +1685,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_opus_quality_test") {
testonly = true
sources = [
"neteq/test/neteq_opus_quality_test.cc",
]
sources = [ "neteq/test/neteq_opus_quality_test.cc" ]
deps = [
":neteq",
@ -1765,9 +1702,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_speed_test") {
testonly = true
sources = [
"neteq/test/neteq_speed_test.cc",
]
sources = [ "neteq/test/neteq_speed_test.cc" ]
deps = [
":neteq",
@ -1782,9 +1717,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_ilbc_quality_test") {
testonly = true
sources = [
"neteq/test/neteq_ilbc_quality_test.cc",
]
sources = [ "neteq/test/neteq_ilbc_quality_test.cc" ]
deps = [
":ilbc",
@ -1803,9 +1736,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_isac_quality_test") {
testonly = true
sources = [
"neteq/test/neteq_isac_quality_test.cc",
]
sources = [ "neteq/test/neteq_isac_quality_test.cc" ]
deps = [
":isac_fix",
@ -1821,9 +1752,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_pcmu_quality_test") {
testonly = true
sources = [
"neteq/test/neteq_pcmu_quality_test.cc",
]
sources = [ "neteq/test/neteq_pcmu_quality_test.cc" ]
deps = [
":g711",
@ -1841,9 +1770,7 @@ if (rtc_include_tests) {
rtc_executable("neteq_pcm16b_quality_test") {
testonly = true
sources = [
"neteq/test/neteq_pcm16b_quality_test.cc",
]
sources = [ "neteq/test/neteq_pcm16b_quality_test.cc" ]
deps = [
":neteq",
@ -1861,9 +1788,7 @@ if (rtc_include_tests) {
rtc_executable("isac_fix_test") {
testonly = true
sources = [
"codecs/isac/fix/test/kenny.cc",
]
sources = [ "codecs/isac/fix/test/kenny.cc" ]
deps = [
":isac_fix",
@ -1871,9 +1796,7 @@ if (rtc_include_tests) {
"../../test:test_support",
]
data = [
"../../resources/speech_and_misc_wb.pcm",
]
data = [ "../../resources/speech_and_misc_wb.pcm" ]
}
rtc_library("isac_test_util") {
@ -1887,9 +1810,7 @@ if (rtc_include_tests) {
rtc_executable("isac_test") {
testonly = true
sources = [
"codecs/isac/main/test/simpleKenny.c",
]
sources = [ "codecs/isac/main/test/simpleKenny.c" ]
deps = [
":isac",
@ -1901,33 +1822,23 @@ if (rtc_include_tests) {
rtc_executable("g711_test") {
testonly = true
sources = [
"codecs/g711/test/testG711.cc",
]
sources = [ "codecs/g711/test/testG711.cc" ]
deps = [
":g711",
]
deps = [ ":g711" ]
}
rtc_executable("g722_test") {
testonly = true
sources = [
"codecs/g722/test/testG722.cc",
]
sources = [ "codecs/g722/test/testG722.cc" ]
deps = [
":g722",
]
deps = [ ":g722" ]
}
rtc_executable("isac_api_test") {
testonly = true
sources = [
"codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc",
]
sources = [ "codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc" ]
deps = [
":isac",
@ -1939,9 +1850,7 @@ if (rtc_include_tests) {
rtc_executable("isac_switch_samprate_test") {
testonly = true
sources = [
"codecs/isac/main/test/SwitchingSampRate/SwitchingSampRate.cc",
]
sources = [ "codecs/isac/main/test/SwitchingSampRate/SwitchingSampRate.cc" ]
deps = [
":isac",
@ -1954,21 +1863,15 @@ if (rtc_include_tests) {
rtc_executable("ilbc_test") {
testonly = true
sources = [
"codecs/ilbc/test/iLBC_test.c",
]
sources = [ "codecs/ilbc/test/iLBC_test.c" ]
deps = [
":ilbc",
]
deps = [ ":ilbc" ]
}
rtc_executable("webrtc_opus_fec_test") {
testonly = true
sources = [
"codecs/opus/opus_fec_test.cc",
]
sources = [ "codecs/opus/opus_fec_test.cc" ]
deps = [
":webrtc_opus",
@ -2147,12 +2050,8 @@ if (rtc_include_tests) {
# TODO(kwiberg): Remove this.
rtc_source_set("audio_decoder_interface") {
visibility += [ "*" ]
sources = [
"codecs/audio_decoder.h",
]
deps = [
"../../api/audio_codecs:audio_codecs_api",
]
sources = [ "codecs/audio_decoder.h" ]
deps = [ "../../api/audio_codecs:audio_codecs_api" ]
}
# For backwards compatibility only! Use
@ -2160,10 +2059,6 @@ rtc_source_set("audio_decoder_interface") {
# TODO(ossu): Remove this.
rtc_source_set("audio_encoder_interface") {
visibility += [ "*" ]
sources = [
"codecs/audio_encoder.h",
]
deps = [
"../../api/audio_codecs:audio_codecs_api",
]
sources = [ "codecs/audio_encoder.h" ]
deps = [ "../../api/audio_codecs:audio_codecs_api" ]
}