zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable clang::find_bad_constructs for remote_bitrate_estimator.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: Id377fcd78166e53aad7c663c3ffec5e57fdb1274
Reviewed-on: https://webrtc-review.googlesource.com/89383
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24049}
This commit is contained in:
Mirko Bonadei
2018-07-18 15:37:01 +02:00
committed by Commit Bot
parent ee01a839d2
commit 64f813e71f
30 changed files with 311 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/bitrate_controller/include/bitrate_controller.h
View File

@ -45,7 +45,7 @@ class BitrateObserver {
int64_t target_set_time,
uint64_t congestion_window) {}
virtual void OnBytesAcked(size_t bytes) {}
virtual size_t pacer_queue_size_in_bytes() { return 0; }
virtual size_t pacer_queue_size_in_bytes();
virtual ~BitrateObserver() {}
};
@ -67,7 +67,7 @@ class BitrateController : public Module, public RtcpBandwidthObserver {
static BitrateController* CreateBitrateController(const Clock* clock,
RtcEventLog* event_log);
virtual ~BitrateController() {}
~BitrateController() override {}
// Deprecated, use raw pointer to BitrateController instance instead.
// Creates RtcpBandwidthObserver caller responsible to delete.