zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Chromium clang plugin warnings

Browse Source 
NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2291503002
Cr-Commit-Position: refs/heads/master@{#13959}
This commit is contained in:
kwiberg
2016-08-29 10:05:24 -07:00
committed by Commit bot
parent e39f251dac
commit 65fc8b9138
11 changed files with 41 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
webrtc/modules/audio_coding/BUILD.gn
View File

@ -917,11 +917,6 @@ if (rtc_include_tests) {
configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
defines = audio_coding_defines
deps = audio_coding_deps + [
@ -943,12 +938,6 @@ if (rtc_include_tests) {
configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
":audio_coding",
"../../:webrtc_common",

2
webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc
View File

@ -47,6 +47,8 @@ AcmSendTestOldApi::AcmSendTestOldApi(InputAudioFile* audio_source,
acm_->RegisterTransportCallback(this);
}
AcmSendTestOldApi::~AcmSendTestOldApi() = default;
bool AcmSendTestOldApi::RegisterCodec(const char* payload_name,
int sampling_freq_hz,
int channels,

2
webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h
View File

@ -32,7 +32,7 @@ class AcmSendTestOldApi : public AudioPacketizationCallback,
AcmSendTestOldApi(InputAudioFile* audio_source,
int source_rate_hz,
int test_duration_ms);
virtual ~AcmSendTestOldApi() {}
~AcmSendTestOldApi() override;
// Registers the send codec. Returns true on success, false otherwise.
bool RegisterCodec(const char* payload_name,

2
webrtc/modules/audio_coding/test/Channel.h
View File

@ -47,7 +47,7 @@ class Channel : public AudioPacketizationCallback {
public:
Channel(int16_t chID = -1);
~Channel();
~Channel() override;
int32_t SendData(FrameType frameType,
uint8_t payloadType,

6
webrtc/modules/audio_coding/test/PCMFile.cc
View File

@ -46,6 +46,12 @@ PCMFile::PCMFile(uint32_t timestamp)
timestamp_ = timestamp;
}
PCMFile::~PCMFile() {
if (pcm_file_) {
fclose(pcm_file_);
}
}
int16_t PCMFile::ChooseFile(std::string* file_name, int16_t max_len,
uint16_t* frequency_hz) {
char tmp_name[MAX_FILE_NAME_LENGTH_BYTE];

6
webrtc/modules/audio_coding/test/PCMFile.h
View File

@ -26,11 +26,7 @@ class PCMFile {
public:
PCMFile();
PCMFile(uint32_t timestamp);
~PCMFile() {
if (pcm_file_ != NULL) {
fclose(pcm_file_);
}
}
~PCMFile();
void Open(const std::string& filename, uint16_t frequency, const char* mode,
bool auto_rewind = false);

4
webrtc/modules/audio_coding/test/utility.h
View File

@ -118,10 +118,8 @@ bool FixedPayloadTypeCodec(const char* payloadName);
class VADCallback : public ACMVADCallback {
public:
VADCallback();
~VADCallback() {
}
int32_t InFrameType(FrameType frame_type);
int32_t InFrameType(FrameType frame_type) override;
void PrintFrameTypes();
void Reset();