zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reformat the WebRTC code base

Browse Source 
Running clang-format with chromium's style guide.

The goal is n-fold:
 * providing consistency and readability (that's what code guidelines are for)
 * preventing noise with presubmit checks and git cl format
 * building on the previous point: making it easier to automatically fix format issues
 * you name it

Please consider using git-hyper-blame to ignore this commit.

Bug: webrtc:9340
Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87
Reviewed-on: https://webrtc-review.googlesource.com/81185
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23660}
This commit is contained in:
Yves Gerey
2018-06-19 15:03:05 +02:00
parent b602123a5a
commit 665174fdbb
1569 changed files with 30495 additions and 30309 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
rtc_base/thread_checker_unittest.cc
View File

@ -38,9 +38,7 @@ class ThreadCheckerClass : public ThreadChecker {
// Verifies that it was called on the same thread as the constructor.
void DoStuff() { RTC_DCHECK(CalledOnValidThread()); }
void DetachFromThread() {
ThreadChecker::DetachFromThread();
}
void DetachFromThread() { ThreadChecker::DetachFromThread(); }
static void MethodOnDifferentThreadImpl();
static void DetachThenCallFromDifferentThreadImpl();
@ -62,9 +60,7 @@ class CallDoStuffOnThread : public Thread {
// New method. Needed since Thread::Join is protected, and it is called by
// the TEST.
void Join() {
Thread::Join();
}
void Join() { Thread::Join(); }
private:
ThreadCheckerClass* thread_checker_class_;
@ -86,9 +82,7 @@ class DeleteThreadCheckerClassOnThread : public Thread {
// New method. Needed since Thread::Join is protected, and it is called by
// the TEST.
void Join() {
Thread::Join();
}
void Join() { Thread::Join(); }
bool has_been_deleted() const { return !thread_checker_class_; }
@ -157,9 +151,7 @@ void ThreadCheckerClass::MethodOnDifferentThreadImpl() {
#if ENABLE_THREAD_CHECKER
TEST(ThreadCheckerDeathTest, MethodNotAllowedOnDifferentThreadInDebug) {
ASSERT_DEATH({
ThreadCheckerClass::MethodOnDifferentThreadImpl();
}, "");
ASSERT_DEATH({ ThreadCheckerClass::MethodOnDifferentThreadImpl(); }, "");
}
#else
TEST(ThreadCheckerTest, MethodAllowedOnDifferentThreadInRelease) {
@ -186,9 +178,8 @@ void ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl() {
#if ENABLE_THREAD_CHECKER
TEST(ThreadCheckerDeathTest, DetachFromThreadInDebug) {
ASSERT_DEATH({
ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl();
}, "");
ASSERT_DEATH({ ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl(); },
"");
}
#else
TEST(ThreadCheckerTest, DetachFromThreadInRelease) {
@ -204,12 +195,12 @@ class ThreadAnnotateTest {
// specific T).
// TODO(danilchap): Find a way to test they do not compile when thread
// annotation checks enabled.
template<typename T>
template <typename T>
void access_var_no_annotate() {
var_thread_ = 42;
}
template<typename T>
template <typename T>
void access_fun_no_annotate() {
function();
}