From 666fb32d1fdd82021ba0cfae4ed80977502298bc Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Mon, 8 Oct 2018 11:31:09 +0200 Subject: [PATCH] Rename DefaultNetworkSimulationConfig into BuiltInNetworkBehaviorConfig. It is done to better show what for this class exists and also restore correspondence between config and interface, that is implemented by configurable object. Bug: webrtc:9630 Change-Id: I28456d1c792d67d9b2a405c8599054137a5d596a Reviewed-on: https://webrtc-review.googlesource.com/c/104003 Commit-Queue: Artem Titov Reviewed-by: Sebastian Jansson Reviewed-by: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#25041} --- api/test/simulated_network.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/api/test/simulated_network.h b/api/test/simulated_network.h index aec300caa2..a159ee7de2 100644 --- a/api/test/simulated_network.h +++ b/api/test/simulated_network.h @@ -42,11 +42,11 @@ struct PacketDeliveryInfo { uint64_t packet_id; }; -// DefaultNetworkSimulationConfig is a default network behavior configuration -// for default network behavior that will be used by WebRTC if no custom +// BuiltInNetworkBehaviorConfig is a built-in network behavior configuration +// for built-in network behavior that will be used by WebRTC if no custom // NetworkBehaviorInterface is provided. -struct DefaultNetworkSimulationConfig { - DefaultNetworkSimulationConfig() {} +struct BuiltInNetworkBehaviorConfig { + BuiltInNetworkBehaviorConfig() {} // Queue length in number of packets. size_t queue_length_packets = 0; // Delay in addition to capacity induced delay. @@ -63,6 +63,10 @@ struct DefaultNetworkSimulationConfig { int avg_burst_loss_length = -1; }; +// TODO(bugs.webrtc.org/9630) remove it after migration to new API. +// Deprecated. DO NOT USE. Use BuiltInNetworkBehaviorConfig instead. +using DefaultNetworkSimulationConfig = BuiltInNetworkBehaviorConfig; + class NetworkBehaviorInterface { public: virtual bool EnqueuePacket(PacketInFlightInfo packet_info) = 0; @@ -75,6 +79,7 @@ class NetworkBehaviorInterface { virtual ~NetworkBehaviorInterface() = default; }; +// TODO(bugs.webrtc.org/9630) remove it after migration to new API. // Deprecated. DO NOT USE. Use NetworkBehaviorInterface instead. using NetworkSimulationInterface = NetworkBehaviorInterface;