zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Stats] Populate "frames" stats for video source.

Browse Source 
Spec: https://www.w3.org/TR/webrtc-stats/#dom-rtcvideosourcestats-frames

Wiring up the "frames" stats with the cumulative fps counter on the video source.

Tests:
./out/Default/peerconnection_unittests
./out/Default/video_engine_tests

Bug: webrtc:12499
Change-Id: I4103f56ed04cb464f5f7e70fbf2d77c25a867a68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208782
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33404}
This commit is contained in:
Di Wu
2021-02-27 00:29:15 -08:00
committed by Commit Bot
parent 5ab9b32ee6
commit 668dbf66ce
9 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pc/rtc_stats_integrationtest.cc
View File

@ -1062,9 +1062,7 @@ class RTCStatsReportVerifier {
// reflect real code.
verifier.TestMemberIsUndefined(video_source.width);
verifier.TestMemberIsUndefined(video_source.height);
// TODO(hbos): When |frames| is implemented test that this member should be
// expected to be non-negative.
verifier.TestMemberIsUndefined(video_source.frames);
verifier.TestMemberIsNonNegative<uint32_t>(video_source.frames);
verifier.TestMemberIsNonNegative<uint32_t>(video_source.frames_per_second);
return verifier.ExpectAllMembersSuccessfullyTested();
}