diff --git a/test/testsupport/perf_test_histogram_writer.cc b/test/testsupport/perf_test_histogram_writer.cc index 523834bcc8..ad70d6801c 100644 --- a/test/testsupport/perf_test_histogram_writer.cc +++ b/test/testsupport/perf_test_histogram_writer.cc @@ -113,6 +113,10 @@ class PerfTestHistogramWriter : public PerfTestResultWriter { proto::UnitAndDirection unit = ParseUnit(units, improve_direction); std::unique_ptr builder = std::make_unique(graph_name, unit); + + // Set all summary options as false - we don't want to generate + // metric_std, metric_count, and so on for all metrics. + builder->SetSummaryOptions(proto::SummaryOptions()); histograms_[measurement_and_story] = std::move(builder); proto::Diagnostic stories; diff --git a/tools_webrtc/perf/catapult_uploader.py b/tools_webrtc/perf/catapult_uploader.py index 96d1080d45..f3ec2ce7ca 100644 --- a/tools_webrtc/perf/catapult_uploader.py +++ b/tools_webrtc/perf/catapult_uploader.py @@ -102,25 +102,9 @@ def _DumpOutput(histograms, output_file): json.dump(_ApplyHacks(histograms.AsDicts()), output_file, indent=4) -# TODO(https://crbug.com/1029452): Remove this once -# https://chromium-review.googlesource.com/c/catapult/+/2094312 lands. -def _HackSummaryOptions(histograms): - for h in histograms: - h.CustomizeSummaryOptions({ - 'avg': False, - 'std': False, - 'count': False, - 'sum': False, - 'min': False, - 'max': False, - 'nans': False, - }) - - def UploadToDashboard(options): histograms = _LoadHistogramSetFromProto(options) _AddBuildInfo(histograms, options) - _HackSummaryOptions(histograms) if options.output_json_file: _DumpOutput(histograms, options.output_json_file)