Stop using LOG macros in favor of RTC_ prefixed macros.
This CL has been generated with the following script: for m in PLOG \ LOG_TAG \ LOG_GLEM \ LOG_GLE_EX \ LOG_GLE \ LAST_SYSTEM_ERROR \ LOG_ERRNO_EX \ LOG_ERRNO \ LOG_ERR_EX \ LOG_ERR \ LOG_V \ LOG_F \ LOG_T_F \ LOG_E \ LOG_T \ LOG_CHECK_LEVEL_V \ LOG_CHECK_LEVEL \ LOG do git grep -l $m | xargs sed -i "s,\b$m\b,RTC_$m,g" done git checkout rtc_base/logging.h git cl format Bug: webrtc:8452 Change-Id: I1a53ef3e0a5ef6e244e62b2e012b864914784600 Reviewed-on: https://webrtc-review.googlesource.com/21325 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20617}
This commit is contained in:
committed by
Commit Bot
parent
34fa309129
commit
675513b96a
@ -31,17 +31,18 @@ bool CommonHeader::Parse(const uint8_t* buffer, size_t size_bytes) {
|
||||
const uint8_t kVersion = 2;
|
||||
|
||||
if (size_bytes < kHeaderSizeBytes) {
|
||||
LOG(LS_WARNING) << "Too little data (" << size_bytes << " byte"
|
||||
<< (size_bytes != 1 ? "s" : "")
|
||||
<< ") remaining in buffer to parse RTCP header (4 bytes).";
|
||||
RTC_LOG(LS_WARNING)
|
||||
<< "Too little data (" << size_bytes << " byte"
|
||||
<< (size_bytes != 1 ? "s" : "")
|
||||
<< ") remaining in buffer to parse RTCP header (4 bytes).";
|
||||
return false;
|
||||
}
|
||||
|
||||
uint8_t version = buffer[0] >> 6;
|
||||
if (version != kVersion) {
|
||||
LOG(LS_WARNING) << "Invalid RTCP header: Version must be "
|
||||
<< static_cast<int>(kVersion) << " but was "
|
||||
<< static_cast<int>(version);
|
||||
RTC_LOG(LS_WARNING) << "Invalid RTCP header: Version must be "
|
||||
<< static_cast<int>(kVersion) << " but was "
|
||||
<< static_cast<int>(version);
|
||||
return false;
|
||||
}
|
||||
|
||||
@ -53,29 +54,31 @@ bool CommonHeader::Parse(const uint8_t* buffer, size_t size_bytes) {
|
||||
padding_size_ = 0;
|
||||
|
||||
if (size_bytes < kHeaderSizeBytes + payload_size_) {
|
||||
LOG(LS_WARNING) << "Buffer too small (" << size_bytes
|
||||
<< " bytes) to fit an RtcpPacket with a header and "
|
||||
<< payload_size_ << " bytes.";
|
||||
RTC_LOG(LS_WARNING) << "Buffer too small (" << size_bytes
|
||||
<< " bytes) to fit an RtcpPacket with a header and "
|
||||
<< payload_size_ << " bytes.";
|
||||
return false;
|
||||
}
|
||||
|
||||
if (has_padding) {
|
||||
if (payload_size_ == 0) {
|
||||
LOG(LS_WARNING) << "Invalid RTCP header: Padding bit set but 0 payload "
|
||||
"size specified.";
|
||||
RTC_LOG(LS_WARNING)
|
||||
<< "Invalid RTCP header: Padding bit set but 0 payload "
|
||||
"size specified.";
|
||||
return false;
|
||||
}
|
||||
|
||||
padding_size_ = payload_[payload_size_ - 1];
|
||||
if (padding_size_ == 0) {
|
||||
LOG(LS_WARNING) << "Invalid RTCP header: Padding bit set but 0 padding "
|
||||
"size specified.";
|
||||
RTC_LOG(LS_WARNING)
|
||||
<< "Invalid RTCP header: Padding bit set but 0 padding "
|
||||
"size specified.";
|
||||
return false;
|
||||
}
|
||||
if (padding_size_ > payload_size_) {
|
||||
LOG(LS_WARNING) << "Invalid RTCP header: Too many padding bytes ("
|
||||
<< padding_size_ << ") for a packet payload size of "
|
||||
<< payload_size_ << " bytes.";
|
||||
RTC_LOG(LS_WARNING) << "Invalid RTCP header: Too many padding bytes ("
|
||||
<< padding_size_ << ") for a packet payload size of "
|
||||
<< payload_size_ << " bytes.";
|
||||
return false;
|
||||
}
|
||||
payload_size_ -= padding_size_;
|
||||
|
||||
Reference in New Issue
Block a user