zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using LOG macros in favor of RTC_ prefixed macros.

Browse Source 
This CL has been generated with the following script:

for m in PLOG \
  LOG_TAG \
  LOG_GLEM \
  LOG_GLE_EX \
  LOG_GLE \
  LAST_SYSTEM_ERROR \
  LOG_ERRNO_EX \
  LOG_ERRNO \
  LOG_ERR_EX \
  LOG_ERR \
  LOG_V \
  LOG_F \
  LOG_T_F \
  LOG_E \
  LOG_T \
  LOG_CHECK_LEVEL_V \
  LOG_CHECK_LEVEL \
  LOG
do
  git grep -l $m | xargs sed -i "s,\b$m\b,RTC_$m,g"
done
git checkout rtc_base/logging.h
git cl format

Bug: webrtc:8452
Change-Id: I1a53ef3e0a5ef6e244e62b2e012b864914784600
Reviewed-on: https://webrtc-review.googlesource.com/21325
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20617}
This commit is contained in:
Mirko Bonadei
2017-11-09 11:09:25 +01:00
committed by Commit Bot
parent 34fa309129
commit 675513b96a
407 changed files with 5753 additions and 5371 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
modules/rtp_rtcp/source/rtcp_transceiver_config.cc
View File

@ -24,43 +24,44 @@ RtcpTransceiverConfig::~RtcpTransceiverConfig() = default;
bool RtcpTransceiverConfig::Validate() const {
if (feedback_ssrc == 0)
LOG(LS_WARNING)
RTC_LOG(LS_WARNING)
<< debug_id
<< "Ssrc 0 may be treated by some implementation as invalid.";
if (cname.empty())
LOG(LS_WARNING) << debug_id << "missing cname for ssrc " << feedback_ssrc;
RTC_LOG(LS_WARNING) << debug_id << "missing cname for ssrc "
<< feedback_ssrc;
if (cname.size() > 255) {
LOG(LS_ERROR) << debug_id << "cname can be maximum 255 characters.";
RTC_LOG(LS_ERROR) << debug_id << "cname can be maximum 255 characters.";
return false;
}
if (max_packet_size < 100) {
LOG(LS_ERROR) << debug_id << "max packet size " << max_packet_size
<< " is too small.";
RTC_LOG(LS_ERROR) << debug_id << "max packet size " << max_packet_size
<< " is too small.";
return false;
}
if (max_packet_size > IP_PACKET_SIZE) {
LOG(LS_ERROR) << debug_id << "max packet size " << max_packet_size
<< " more than " << IP_PACKET_SIZE << " is unsupported.";
RTC_LOG(LS_ERROR) << debug_id << "max packet size " << max_packet_size
<< " more than " << IP_PACKET_SIZE << " is unsupported.";
return false;
}
if (!outgoing_transport) {
LOG(LS_ERROR) << debug_id << "outgoing transport must be set";
RTC_LOG(LS_ERROR) << debug_id << "outgoing transport must be set";
return false;
}
if (report_period_ms <= 0) {
LOG(LS_ERROR) << debug_id << "period " << report_period_ms
<< "ms between reports should be positive.";
RTC_LOG(LS_ERROR) << debug_id << "period " << report_period_ms
<< "ms between reports should be positive.";
return false;
}
if (schedule_periodic_compound_packets && !task_queue) {
LOG(LS_ERROR) << debug_id
<< "missing task queue for periodic compound packets";
RTC_LOG(LS_ERROR) << debug_id
<< "missing task queue for periodic compound packets";
return false;
}
// TODO(danilchap): Remove or update the warning when RtcpTransceiver supports
// send-only sessions.
if (receive_statistics == nullptr)
LOG(LS_WARNING)
RTC_LOG(LS_WARNING)
<< debug_id
<< "receive statistic should be set to generate rtcp report blocks.";
return true;