zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate EventFactory and delete all usage.

Browse Source 
Will be deleted as soon as downstream calls of
VideoCodingModule::Create are updated.

Tbr: sprang@webrtc.org  # Trivial change in video/
Bug: webrtc:3380
Change-Id: Iaeb6da2fb68991225fe9086ddddd4a553e1620b4
Reviewed-on: https://webrtc-review.googlesource.com/c/107890
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25554}
This commit is contained in:
Niels Möller
2018-11-07 16:36:22 +01:00
committed by Commit Bot
parent 54b4924349
commit 689983f6bc
11 changed files with 29 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/video_coding/video_coding_impl.cc
View File

@ -81,17 +81,13 @@ class EncodedImageCallbackWrapper : public EncodedImageCallback {
class VideoCodingModuleImpl : public VideoCodingModule {
public:
VideoCodingModuleImpl(Clock* clock,
EventFactory* event_factory,
EventFactory* /* event_factory */,
NackSender* nack_sender,
KeyFrameRequestSender* keyframe_request_sender)
: VideoCodingModule(),
sender_(clock, &post_encode_callback_),
timing_(new VCMTiming(clock)),
receiver_(clock,
event_factory,
timing_.get(),
nack_sender,
keyframe_request_sender) {}
receiver_(clock, timing_.get(), nack_sender, keyframe_request_sender) {}
virtual ~VideoCodingModuleImpl() {}
@ -221,11 +217,9 @@ class VideoCodingModuleImpl : public VideoCodingModule {
// DEPRECATED. Create method for current interface, will be removed when the
// new jitter buffer is in place.
VideoCodingModule* VideoCodingModule::Create(Clock* clock,
EventFactory* event_factory) {
VideoCodingModule* VideoCodingModule::Create(Clock* clock) {
RTC_DCHECK(clock);
RTC_DCHECK(event_factory);
return new VideoCodingModuleImpl(clock, event_factory, nullptr, nullptr);
return new VideoCodingModuleImpl(clock, nullptr, nullptr, nullptr);
}
} // namespace webrtc