zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update old TODO comments

Browse Source 
Bug: None
Change-Id: I96850df6cfa19303043108a59ef60d7b686ec747
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267661
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37436}
This commit is contained in:
Niels Möller
2022-07-05 08:55:19 +02:00
committed by WebRTC LUCI CQ
parent c8152fe4a8
commit 6939f63ca1
16 changed files with 36 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
api/video/video_stream_encoder_observer.h
View File

@ -53,7 +53,6 @@ class VideoStreamEncoderObserver : public CpuOveruseMetricsObserver {
bool framerate_scaling_enabled;
};
// TODO(nisse): Duplicates enum EncodedImageCallback::DropReason.
enum class DropReason {
kSource,
kEncoderQueue,
@ -66,7 +65,7 @@ class VideoStreamEncoderObserver : public CpuOveruseMetricsObserver {
virtual void OnIncomingFrame(int width, int height) = 0;
// TODO(nisse): Merge into one callback per encoded frame.
// TODO(bugs.webrtc.org/8504): Merge into one callback per encoded frame.
using CpuOveruseMetricsObserver::OnEncodedFrameTimeMeasured;
virtual void OnSendEncodedImage(const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_info) = 0;
@ -105,10 +104,10 @@ class VideoStreamEncoderObserver : public CpuOveruseMetricsObserver {
// down.
virtual void OnEncoderInternalScalerUpdate(bool is_scaled) {}
// TODO(nisse): VideoStreamEncoder wants to query the stats, which makes this
// not a pure observer. GetInputFrameRate is needed for the cpu adaptation, so
// can be deleted if that responsibility is moved out to a VideoStreamAdaptor
// class.
// TODO(bugs.webrtc.org/14246): VideoStreamEncoder wants to query the stats,
// which makes this not a pure observer. GetInputFrameRate is needed for the
// cpu adaptation, so can be deleted if that responsibility is moved out to a
// VideoStreamAdaptor class.
virtual int GetInputFrameRate() const = 0;
};