zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fully qualify googletest symbols.

Browse Source 
Semi-automatically created with:

git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g"
git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g"
git cl format

After this, two .cc files failed to compile and I have fixed them
manually.

Bug: webrtc:10523
Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27526}
This commit is contained in:
Mirko Bonadei
2019-04-09 15:11:12 +02:00
committed by Commit Bot
parent a857698d54
commit 6a489f22c7
210 changed files with 818 additions and 808 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc
View File

@ -16,7 +16,7 @@
#include "system_wrappers/include/cpu_features_wrapper.h"
#include "test/gtest.h"
class FilterBanksTest : public testing::Test {
class FilterBanksTest : public ::testing::Test {
protected:
// Pass a function pointer to the Tester function.
void RTC_NO_SANITIZE("signed-integer-overflow") // bugs.webrtc.org/5513

2
modules/audio_coding/codecs/isac/fix/source/filters_unittest.cc
View File

@ -12,7 +12,7 @@
#include "system_wrappers/include/cpu_features_wrapper.h"
#include "test/gtest.h"
class FiltersTest : public testing::Test {
class FiltersTest : public ::testing::Test {
protected:
// Pass a function pointer to the Tester function.
void FiltersTester(AutocorrFix WebRtcIsacfix_AutocorrFixFunction) {

2
modules/audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc
View File

@ -12,7 +12,7 @@
#include "system_wrappers/include/cpu_features_wrapper.h"
#include "test/gtest.h"
class LpcMaskingModelTest : public testing::Test {
class LpcMaskingModelTest : public ::testing::Test {
protected:
// Pass a function pointer to the Tester function.
void CalculateResidualEnergyTester(

2
modules/audio_coding/codecs/isac/fix/source/transform_unittest.cc
View File

@ -136,7 +136,7 @@ static const int16_t time2spec_out_expected_2[kSamples] = {
294, -339, 344, -396, 407, -429, 438, -439, 485, -556,
629, -612, 637, -645, 661, -737, 829, -830, 831, -1041};
class TransformTest : public testing::Test {
class TransformTest : public ::testing::Test {
protected:
TransformTest() { WebRtcSpl_Init(); }

4
modules/audio_coding/codecs/isac/unittest.cc
View File

@ -210,7 +210,7 @@ struct IsacTestParam {
}
};
class IsacCommonTest : public testing::TestWithParam<IsacTestParam> {};
class IsacCommonTest : public ::testing::TestWithParam<IsacTestParam> {};
} // namespace
@ -252,6 +252,6 @@ std::vector<IsacTestParam> TestCases() {
return cases;
}
INSTANTIATE_TEST_SUITE_P(, IsacCommonTest, testing::ValuesIn(TestCases()));
INSTANTIATE_TEST_SUITE_P(, IsacCommonTest, ::testing::ValuesIn(TestCases()));
} // namespace webrtc

2
modules/audio_coding/codecs/opus/audio_decoder_multi_channel_opus_unittest.cc
View File

@ -94,7 +94,7 @@ TEST(AudioDecoderMultiOpusTest, ValidSdpToConfigProducesCorrectConfig) {
EXPECT_TRUE(decoder_config->IsOk());
EXPECT_EQ(decoder_config->coupled_streams, 2);
EXPECT_THAT(decoder_config->channel_mapping,
testing::ContainerEq(std::vector<unsigned char>({3, 1, 2, 0})));
::testing::ContainerEq(std::vector<unsigned char>({3, 1, 2, 0})));
}
TEST(AudioDecoderMultiOpusTest, InvalidSdpToConfigDoesNotProduceConfig) {

2
modules/audio_coding/codecs/tools/audio_codec_speed_test.h
View File

@ -22,7 +22,7 @@ namespace webrtc {
// <channels, bit_rate, file_name, extension, if_save_output>.
typedef std::tuple<size_t, int, std::string, std::string, bool> coding_param;
class AudioCodecSpeedTest : public testing::TestWithParam<coding_param> {
class AudioCodecSpeedTest : public ::testing::TestWithParam<coding_param> {
protected:
AudioCodecSpeedTest(int block_duration_ms,
int input_sampling_khz,