zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not compile webrtc_lib_link_test if is_asan=true.

Browse Source 
This should avoid to get errors like the ones below when is_asan=true
and target_os="mac":

warning: (x86_64)  could not find object file symbol for symbol _write_mb_features
warning: (x86_64)  could not find object file symbol for symbol _update_mode
warning: (x86_64)  could not find object file symbol for symbol _vp8cx_base_skip_false_prob
warning: (x86_64)  could not find object file symbol for symbol _default_coef_counts
warning: (x86_64)  could not find object file symbol for symbol _vpx_skin_pixel

Bug: webrtc:11027
Change-Id: Iebcb55a43d1ed5c8d1ce43d456c0e83ffa5cc2c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158000
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29587}
This commit is contained in:
Mirko Bonadei
2019-10-23 07:55:04 -07:00
committed by Commit Bot
parent 21bfa401dd
commit 6adb0a2684
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
BUILD.gn
View File

@ -42,7 +42,6 @@ if (!build_with_chromium) {
":rtc_unittests", ":rtc_unittests",
":slow_tests", ":slow_tests",
":video_engine_tests", ":video_engine_tests",
":webrtc_lib_link_test",
":webrtc_nonparallel_tests", ":webrtc_nonparallel_tests",
":webrtc_perf_tests", ":webrtc_perf_tests",
"common_audio:common_audio_unittests", "common_audio:common_audio_unittests",
@ -66,6 +65,12 @@ if (!build_with_chromium) {
"video:sv_loopback", "video:sv_loopback",
"video:video_loopback", "video:video_loopback",
] ]
if (!is_asan) {
# Do not build :webrtc_lib_link_test because lld complains on some OS
# (e.g. when target_os = "mac") when is_asan=true. For more details,
# see bugs.webrtc.org/11027#c5.
deps += [ ":webrtc_lib_link_test" ]
}
if (is_android) { if (is_android) {
deps += [ deps += [
":android_junit_tests", ":android_junit_tests",