zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Potential bug in RTP packet.

Browse Source 
A potential bug was introduced in "Refactor to remove direct memory
dependency on kMaxId" due to a memory restructuring,
commit c5744b8b21b627213286f1b6f2c65da5df9ce8d0

Bug: webrtc:7990
Change-Id: I0dcaf47e1c1e361d65220c278a2326d6f2686af7
Reviewed-on: https://webrtc-review.googlesource.com/101642
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24814}
This commit is contained in:
Johannes Kron
2018-09-24 17:19:52 +02:00
committed by Commit Bot
parent 965e7942a3
commit 6ea771933d
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
modules/rtp_rtcp/source/rtp_packet_unittest.cc
View File

@ -365,6 +365,22 @@ TEST(RtpPacketTest, ParseWith2Extensions) {
EXPECT_EQ(kAudioLevel, audio_level);
}
TEST(RtpPacketTest, ParseSecondPacketWithFewerExtensions) {
RtpPacketToSend::ExtensionManager extensions;
extensions.Register(kRtpExtensionTransmissionTimeOffset,
kTransmissionOffsetExtensionId);
extensions.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId);
RtpPacketReceived packet(&extensions);
EXPECT_TRUE(packet.Parse(kPacketWithTOAndAL, sizeof(kPacketWithTOAndAL)));
EXPECT_TRUE(packet.HasExtension<TransmissionOffset>());
EXPECT_TRUE(packet.HasExtension<AudioLevel>());
// Second packet without audio level.
EXPECT_TRUE(packet.Parse(kPacketWithTO, sizeof(kPacketWithTO)));
EXPECT_TRUE(packet.HasExtension<TransmissionOffset>());
EXPECT_FALSE(packet.HasExtension<AudioLevel>());
}
TEST(RtpPacketTest, ParseWithAllFeatures) {
RtpPacketToSend::ExtensionManager extensions;
extensions.Register(kRtpExtensionTransmissionTimeOffset,