zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete old StringToProto signature

Browse Source 
Bug: webrtc:13579
Change-Id: I9bc01ce6e41a906d962522d0b395702db7a578f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263583
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37065}
This commit is contained in:
Niels Möller
2022-05-25 11:00:36 +02:00
committed by WebRTC LUCI CQ
parent 874517b5f5
commit 6ef0a3816e
2 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
p2p/base/port.cc
View File

@ -89,15 +89,6 @@ absl::optional<ProtocolType> StringToProto(absl::string_view proto_name) {
return absl::nullopt; return absl::nullopt;
} }
bool StringToProto(const char* value, ProtocolType* proto) {
if (absl::optional<ProtocolType> type = StringToProto(value);
type.has_value()) {
*proto = *type;
return true;
}
return false;
}
// RFC 6544, TCP candidate encoding rules. // RFC 6544, TCP candidate encoding rules.
const int DISCARD_PORT = 9; const int DISCARD_PORT = 9;
const char TCPTYPE_ACTIVE_STR[] = "active"; const char TCPTYPE_ACTIVE_STR[] = "active";

3
p2p/base/port.h
View File

@ -128,9 +128,6 @@ typedef std::vector<CandidateStats> CandidateStatsList;
const char* ProtoToString(ProtocolType proto); const char* ProtoToString(ProtocolType proto);
absl::optional<ProtocolType> StringToProto(absl::string_view proto_name); absl::optional<ProtocolType> StringToProto(absl::string_view proto_name);
// TODO(bugs.webrtc.org/13579): Delete once downstream usage is updated.
[[deprecated]] bool StringToProto(const char* value, ProtocolType* proto);
struct ProtocolAddress { struct ProtocolAddress {
rtc::SocketAddress address; rtc::SocketAddress address;
ProtocolType proto; ProtocolType proto;