Adding NOLINT for typedefs.h and common_types.h
Now that we have moved WebRTC from src/webrtc to src/, common_types.h and typedefs.h are triggering a cpplint error. The cpplint complaint is: Include the directory when naming .h files [build/include] [4] This CL disables the error but we have to remove these two headers from the root directory. NOPRESUBMIT=true Bug: webrtc:5876 Change-Id: I08e1b69aadcc4b28ab83bf25e3819d135d41d333 Reviewed-on: https://webrtc-review.googlesource.com/1577 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19859}
This commit is contained in:
committed by
Commit Bot
parent
563934e726
commit
7120742701
@ -18,7 +18,7 @@
|
||||
#include "modules/video_coding/include/video_coding.h"
|
||||
#include "modules/video_coding/generic_decoder.h"
|
||||
#include "modules/video_coding/generic_encoder.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "rtc_base/numerics/percentile_filter.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
#include "rtc_base/checks.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -18,7 +18,7 @@
|
||||
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
#include "test/gmock.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
|
||||
#include "modules/video_coding/codecs/test/packet_manipulator.h"
|
||||
#include "test/gmock.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
#include "common_video/include/video_frame.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
@ -16,7 +16,7 @@
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
#include "test/gtest.h"
|
||||
#include "test/testsupport/unittest_utils.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
namespace test {
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include <vector>
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
namespace test {
|
||||
|
||||
@ -18,7 +18,7 @@
|
||||
#include <vector>
|
||||
|
||||
#include "api/video/i420_buffer.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/codecs/vp8/simulcast_rate_allocator.h"
|
||||
#include "modules/video_coding/include/video_codec_initializer.h"
|
||||
#include "modules/video_coding/utility/default_video_bitrate_allocator.h"
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "media/engine/webrtcvideodecoderfactory.h"
|
||||
#include "media/engine/webrtcvideoencoderfactory.h"
|
||||
#include "modules/video_coding/codecs/test/packet_manipulator.h"
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#include <memory>
|
||||
|
||||
#include "api/video/i420_buffer.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/codecs/test/mock/mock_packet_manipulator.h"
|
||||
#include "modules/video_coding/codecs/test/videoprocessor.h"
|
||||
#include "modules/video_coding/include/mock/mock_video_codec_interface.h"
|
||||
@ -24,7 +24,7 @@
|
||||
#include "test/testsupport/packet_reader.h"
|
||||
#include "test/testsupport/unittest_utils.h"
|
||||
#include "test/video_codec_settings.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
using ::testing::_;
|
||||
using ::testing::AtLeast;
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#ifndef MODULES_VIDEO_CODING_CODECS_VP8_INCLUDE_VP8_COMMON_TYPES_H_
|
||||
#define MODULES_VIDEO_CODING_CODECS_VP8_INCLUDE_VP8_COMMON_TYPES_H_
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
#include "modules/video_coding/utility/frame_dropper.h"
|
||||
#include "rtc_base/rate_statistics.h"
|
||||
#include "rtc_base/timeutils.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -14,7 +14,7 @@
|
||||
|
||||
#include <vector>
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
struct vpx_codec_enc_cfg;
|
||||
typedef struct vpx_codec_enc_cfg vpx_codec_enc_cfg_t;
|
||||
|
||||
@ -20,7 +20,7 @@
|
||||
#include "libyuv/scale.h" // NOLINT
|
||||
#include "libyuv/convert.h" // NOLINT
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/libyuv/include/webrtc_libyuv.h"
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/codecs/vp8/include/vp8_common_types.h"
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
#include <set>
|
||||
#include <vector>
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include <vector>
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/include/video_frame.h"
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
|
||||
@ -18,7 +18,7 @@
|
||||
#include "modules/video_coding/encoded_frame.h"
|
||||
#include "modules/video_coding/jitter_buffer_common.h"
|
||||
#include "modules/video_coding/session_info.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -12,7 +12,7 @@
|
||||
#define MODULES_VIDEO_CODING_FRAME_OBJECT_H_
|
||||
|
||||
#include "api/optional.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/encoded_frame.h"
|
||||
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include "modules/video_coding/include/video_coding_defines.h"
|
||||
#include "test/gmock.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -16,7 +16,7 @@
|
||||
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
#include "test/gmock.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -16,10 +16,10 @@
|
||||
#include "api/video/video_frame.h"
|
||||
#include "api/video_codecs/video_decoder.h"
|
||||
#include "api/video_codecs/video_encoder.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/include/video_error_codes.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -18,7 +18,7 @@
|
||||
// For EncodedImage
|
||||
#include "common_video/include/video_frame.h"
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#ifndef MODULES_VIDEO_CODING_INTER_FRAME_DELAY_H_
|
||||
#define MODULES_VIDEO_CODING_INTER_FRAME_DELAY_H_
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#ifndef MODULES_VIDEO_CODING_INTERNAL_DEFINES_H_
|
||||
#define MODULES_VIDEO_CODING_INTERNAL_DEFINES_H_
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -29,7 +29,7 @@
|
||||
#include "rtc_base/constructormagic.h"
|
||||
#include "rtc_base/criticalsection.h"
|
||||
#include "rtc_base/thread_annotations.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#ifndef MODULES_VIDEO_CODING_JITTER_BUFFER_COMMON_H_
|
||||
#define MODULES_VIDEO_CODING_JITTER_BUFFER_COMMON_H_
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include "modules/video_coding/rtt_filter.h"
|
||||
#include "rtc_base/rollingaccumulator.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -18,7 +18,7 @@
|
||||
|
||||
#include "modules/video_coding/internal_defines.h"
|
||||
#include "rtc_base/numerics/exp_filter.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
namespace media_optimization {
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/jitter_buffer_common.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -10,7 +10,7 @@
|
||||
|
||||
#include "modules/video_coding/qp_parser.h"
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/utility/vp8_header_parser.h"
|
||||
#include "modules/video_coding/utility/vp9_uncompressed_header_parser.h"
|
||||
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
#ifndef MODULES_VIDEO_CODING_RTT_FILTER_H_
|
||||
#define MODULES_VIDEO_CODING_RTT_FILTER_H_
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -17,7 +17,7 @@
|
||||
#include "modules/include/module_common_types.h"
|
||||
#include "modules/video_coding/include/video_coding.h"
|
||||
#include "modules/video_coding/packet.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
// Used to pass data from jitter buffer to session info.
|
||||
|
||||
@ -14,7 +14,7 @@
|
||||
|
||||
#include "modules/video_coding/packet.h"
|
||||
#include "rtc_base/constructormagic.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
|
||||
#include <memory>
|
||||
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -16,7 +16,7 @@
|
||||
#include "modules/video_coding/codec_timer.h"
|
||||
#include "rtc_base/criticalsection.h"
|
||||
#include "rtc_base/thread_annotations.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -14,7 +14,7 @@
|
||||
#include <cstddef>
|
||||
|
||||
#include "rtc_base/numerics/exp_filter.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -14,7 +14,7 @@
|
||||
|
||||
#include "modules/video_coding/utility/frame_dropper.h"
|
||||
#include "test/gmock.h"
|
||||
#include "typedefs.h"
|
||||
#include "typedefs.h" // NOLINT(build/include)
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
||||
@ -15,7 +15,7 @@
|
||||
|
||||
#include "api/optional.h"
|
||||
#include "api/video_codecs/video_encoder.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/utility/moving_average.h"
|
||||
#include "rtc_base/sequenced_task_checker.h"
|
||||
|
||||
|
||||
@ -10,7 +10,7 @@
|
||||
|
||||
#include "modules/video_coding/include/video_codec_initializer.h"
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/include/video_bitrate_allocator.h"
|
||||
#include "modules/video_coding/codecs/vp8/screenshare_layers.h"
|
||||
#include "modules/video_coding/codecs/vp8/simulcast_rate_allocator.h"
|
||||
|
||||
@ -10,7 +10,7 @@
|
||||
|
||||
#include "api/video_codecs/video_encoder.h"
|
||||
#include "common_video/include/video_bitrate_allocator.h"
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/codecs/vp8/temporal_layers.h"
|
||||
#include "modules/video_coding/include/video_codec_initializer.h"
|
||||
#include "test/gtest.h"
|
||||
|
||||
@ -13,7 +13,7 @@
|
||||
#include <algorithm>
|
||||
#include <utility>
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/include/video_bitrate_allocator.h"
|
||||
#include "common_video/libyuv/include/webrtc_libyuv.h"
|
||||
#include "modules/video_coding/codecs/vp8/temporal_layers.h"
|
||||
|
||||
@ -8,7 +8,7 @@
|
||||
* be found in the AUTHORS file in the root of the source tree.
|
||||
*/
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/libyuv/include/webrtc_libyuv.h"
|
||||
#include "modules/video_coding/encoded_frame.h"
|
||||
#include "modules/video_coding/include/video_codec_interface.h"
|
||||
|
||||
@ -11,7 +11,7 @@
|
||||
|
||||
#include <algorithm> // std::max
|
||||
|
||||
#include "common_types.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "common_video/include/video_bitrate_allocator.h"
|
||||
#include "common_video/libyuv/include/webrtc_libyuv.h"
|
||||
#include "modules/video_coding/codecs/vp8/temporal_layers.h"
|
||||
|
||||
Reference in New Issue
Block a user