zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add RTCConfiguration getter and setter methods. The immediate plan is to move some flags into an embedded MediaConfig (https://codereview.webrtc.org/1818033002/), which will be possible after Chrome is updated to use these new setter methods.

Browse Source 
BUG=webrtc:4906
R=hbos@google.com, hbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1836083003 .

Cr-Commit-Position: refs/heads/master@{#12177}
This commit is contained in:
Niels Möller
2016-03-31 12:59:59 +02:00
parent 82b750b80e
commit 71bdda0ede
2 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
webrtc/api/peerconnectioninterface.h
View File

@ -223,6 +223,36 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// TODO(hbos): Change into class with private data and public getters.
struct RTCConfiguration {
// This struct is subject to reorganization, both for naming
// consistency, and to group settings to match where they are used
// in the implementation. To do that, we need getter and setter
// methods for all settings which are of interest to applications,
// Chrome in particular.
bool dscp() { return enable_dscp.value_or(false); }
void set_dscp(bool enable) { enable_dscp = rtc::Optional<bool>(enable); }
// TODO(nisse): The corresponding flag in MediaConfig and
// elsewhere should be renamed enable_cpu_adaptation.
bool cpu_adaptation() { return cpu_overuse_detection.value_or(true); }
void set_cpu_adaptation(bool enable) {
cpu_overuse_detection = rtc::Optional<bool>(enable);
}
// TODO(nisse): Currently no getter method, since it collides with
// the flag itself. Add when the flag is moved to MediaConfig.
void set_suspend_below_min_bitrate(bool enable) {
suspend_below_min_bitrate = rtc::Optional<bool>(enable);
}
// TODO(nisse): The negation in the corresponding MediaConfig
// attribute is inconsistent, and it should be renamed at some
// point.
bool prerenderer_smoothing() { return !disable_prerenderer_smoothing; }
void set_prerenderer_smoothing(bool enable) {
disable_prerenderer_smoothing = !enable;
}
static const int kUndefined = -1;
// Default maximum number of packets in the audio jitter buffer.
static const int kAudioJitterBufferMaxPackets = 50;