From 72b7524d878889caa47621d32d3b8a07a5f2fb79 Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Mon, 15 Apr 2019 15:10:18 +0200 Subject: [PATCH] Adds more stats to CallStatsCollector. Also adding checks to avoid adding empty stats. Bug: webrtc:10365 Change-Id: I37ab32a3d4271fcad419f17841a8d2e524d73245 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133020 Reviewed-by: Rasmus Brandt Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#27625} --- test/scenario/performance_stats.h | 2 ++ test/scenario/stats_collection.cc | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/test/scenario/performance_stats.h b/test/scenario/performance_stats.h index 19798760b4..429d60f256 100644 --- a/test/scenario/performance_stats.h +++ b/test/scenario/performance_stats.h @@ -134,6 +134,8 @@ struct VideoQualityStats { struct CollectedCallStats { SampleStats target_rate; + SampleStats pacer_delay; + SampleStats round_trip_time; SampleStats memory_usage; }; diff --git a/test/scenario/stats_collection.cc b/test/scenario/stats_collection.cc index 104c824c56..817d947378 100644 --- a/test/scenario/stats_collection.cc +++ b/test/scenario/stats_collection.cc @@ -112,7 +112,12 @@ void VideoLayerAnalyzer::HandleRenderedFrame(const VideoFramePair& sample) { } void CallStatsCollector::AddStats(Call::Stats sample) { - stats_.target_rate.AddSampleBps(sample.send_bandwidth_bps); + if (sample.send_bandwidth_bps > 0) + stats_.target_rate.AddSampleBps(sample.send_bandwidth_bps); + if (sample.pacer_delay_ms > 0) + stats_.pacer_delay.AddSample(TimeDelta::ms(sample.pacer_delay_ms)); + if (sample.rtt_ms > 0) + stats_.round_trip_time.AddSample(TimeDelta::ms(sample.rtt_ms)); stats_.memory_usage.AddSample(rtc::GetProcessResidentSizeBytes()); }