diff --git a/api/test/peerconnection_quality_test_fixture.h b/api/test/peerconnection_quality_test_fixture.h index 94ccb04cf8..8d07ccb5ba 100644 --- a/api/test/peerconnection_quality_test_fixture.h +++ b/api/test/peerconnection_quality_test_fixture.h @@ -501,15 +501,7 @@ class PeerConnectionE2EQualityTestFixture { virtual PeerHandle* AddPeer( rtc::Thread* network_thread, rtc::NetworkManager* network_manager, - rtc::FunctionView configurer) { - return nullptr; - } - virtual PeerHandle* AddAndReturnPeer( - rtc::Thread* network_thread, - rtc::NetworkManager* network_manager, - rtc::FunctionView configurer) { - return nullptr; - } + rtc::FunctionView configurer) = 0; // Runs the media quality test, which includes setting up the call with // configured participants, running it according to provided `run_params` and // terminating it properly at the end. During call duration media quality diff --git a/test/pc/e2e/peer_connection_quality_test.cc b/test/pc/e2e/peer_connection_quality_test.cc index 69c5ce9678..684076cc51 100644 --- a/test/pc/e2e/peer_connection_quality_test.cc +++ b/test/pc/e2e/peer_connection_quality_test.cc @@ -154,8 +154,7 @@ void PeerConnectionE2EQualityTest::AddQualityMetricsReporter( quality_metrics_reporters_.push_back(std::move(quality_metrics_reporter)); } -PeerConnectionE2EQualityTest::PeerHandle* -PeerConnectionE2EQualityTest::AddAndReturnPeer( +PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer( rtc::Thread* network_thread, rtc::NetworkManager* network_manager, rtc::FunctionView configurer) { @@ -166,13 +165,6 @@ PeerConnectionE2EQualityTest::AddAndReturnPeer( return &peer_handles_.back(); } -PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer( - rtc::Thread* network_thread, - rtc::NetworkManager* network_manager, - rtc::FunctionView configurer) { - return AddAndReturnPeer(network_thread, network_manager, configurer); -} - void PeerConnectionE2EQualityTest::Run(RunParams run_params) { SetDefaultValuesForMissingParams(&run_params, &peer_configurations_); ValidateParams(run_params, peer_configurations_); diff --git a/test/pc/e2e/peer_connection_quality_test.h b/test/pc/e2e/peer_connection_quality_test.h index 6a3b68dd3c..4426ee7553 100644 --- a/test/pc/e2e/peer_connection_quality_test.h +++ b/test/pc/e2e/peer_connection_quality_test.h @@ -72,10 +72,6 @@ class PeerConnectionE2EQualityTest rtc::Thread* network_thread, rtc::NetworkManager* network_manager, rtc::FunctionView configurer) override; - PeerHandle* AddAndReturnPeer( - rtc::Thread* network_thread, - rtc::NetworkManager* network_manager, - rtc::FunctionView configurer) override; void Run(RunParams run_params) override; TimeDelta GetRealTestDuration() const override {