From 74cd1ef9f59d26fd651325e608d25fdb1319d83e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20de=20Vicente=20Pe=C3=B1a?= Date: Thu, 11 Oct 2018 10:21:18 +0200 Subject: [PATCH] AEC3: Enabling by default the use of the stationarity properties at render at init MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In this CL the use of the stationarity properties at init is set to true by default. Bug: webrtc:9865, chromium:894439 Change-Id: I716ce0d792a50616dc38cc0ba6f2c702549a81cc Reviewed-on: https://webrtc-review.googlesource.com/c/105303 Reviewed-by: Per Åhgren Commit-Queue: Jesus de Vicente Pena Cr-Commit-Position: refs/heads/master@{#25123} --- api/audio/echo_canceller3_config.h | 2 +- modules/audio_processing/aec3/echo_canceller3.cc | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/api/audio/echo_canceller3_config.h b/api/audio/echo_canceller3_config.h index e7dc0825e3..039f76f6e1 100644 --- a/api/audio/echo_canceller3_config.h +++ b/api/audio/echo_canceller3_config.h @@ -100,7 +100,7 @@ struct RTC_EXPORT EchoCanceller3Config { float audibility_threshold_mf = 10; float audibility_threshold_hf = 10; bool use_stationary_properties = true; - bool use_stationarity_properties_at_init = false; + bool use_stationarity_properties_at_init = true; } echo_audibility; struct RenderLevels { diff --git a/modules/audio_processing/aec3/echo_canceller3.cc b/modules/audio_processing/aec3/echo_canceller3.cc index b78155e653..f0d31ff044 100644 --- a/modules/audio_processing/aec3/echo_canceller3.cc +++ b/modules/audio_processing/aec3/echo_canceller3.cc @@ -70,6 +70,11 @@ bool DeactivateStationarityProperties() { "WebRTC-Aec3UseStationarityPropertiesKillSwitch"); } +bool DeactivateStationarityPropertiesAtInit() { + return field_trial::IsEnabled( + "WebRTC-Aec3UseStationarityPropertiesAtInitKillSwitch"); +} + // Method for adjusting config parameter dependencies.. EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) { EchoCanceller3Config adjusted_cfg = config; @@ -138,6 +143,10 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) { adjusted_cfg.echo_audibility.use_stationary_properties = false; } + if (DeactivateStationarityPropertiesAtInit()) { + adjusted_cfg.echo_audibility.use_stationarity_properties_at_init = false; + } + return adjusted_cfg; }