zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update ObjCVideoEncoder to use GetEncoderInfo()

Browse Source 
This method replaces GetScalingSettings(), GetImpementationName() and
SupportsNativeHandle().

Bug: webrtc:9890
Change-Id: I8a4b13414f66c41f6697ed84854424ab2d8e18e4
Reviewed-on: https://webrtc-review.googlesource.com/c/109460
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25538}
This commit is contained in:
Erik Språng
2018-11-05 14:57:59 +01:00
committed by Commit Bot
parent 7b3c76b44f
commit 7553c02b1e
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
sdk/objc/native/src/objc_video_encoder_factory.mm
View File

@ -90,16 +90,17 @@ class ObjCVideoEncoder : public VideoEncoder {
return [encoder_ setBitrate:bitrate framerate:framerate]; return [encoder_ setBitrate:bitrate framerate:framerate];
} }
bool SupportsNativeHandle() const { return true; } VideoEncoder::EncoderInfo GetEncoderInfo() const {
EncoderInfo info;
info.supports_native_handle = true;
info.implementation_name = implementation_name_;
VideoEncoder::ScalingSettings GetScalingSettings() const {
RTCVideoEncoderQpThresholds *qp_thresholds = [encoder_ scalingSettings]; RTCVideoEncoderQpThresholds *qp_thresholds = [encoder_ scalingSettings];
return qp_thresholds ? ScalingSettings(qp_thresholds.low, qp_thresholds.high) : info.scaling_settings = qp_thresholds ? ScalingSettings(qp_thresholds.low, qp_thresholds.high) :
ScalingSettings::kOff; ScalingSettings::kOff;
return info;
} }
const char *ImplementationName() const { return implementation_name_.c_str(); }
private: private:
id<RTCVideoEncoder> encoder_; id<RTCVideoEncoder> encoder_;
const std::string implementation_name_; const std::string implementation_name_;